From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570AbcFPQhz (ORCPT ); Thu, 16 Jun 2016 12:37:55 -0400 Received: from mail.kernel.org ([198.145.29.136]:32960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752653AbcFPQhy (ORCPT ); Thu, 16 Jun 2016 12:37:54 -0400 Date: Thu, 16 Jun 2016 13:37:45 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Adrian Hunter , Jiri Olsa , linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH RFC 0/3] perf script: Add callindent option Message-ID: <20160616163745.GC13337@kernel.org> References: <1466080474-22576-1-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466080474-22576-1-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 16, 2016 at 03:34:31PM +0300, Adrian Hunter escreveu: > Hi > > Andi Kleen sent a couple of patches to add a callindent option to > perf script. If Andi is agreeable, I would like to propose an > alternative implementation. Andi? - Arnaldo > While there are some differences in the resulting output, the main > differences are: > > 1. Tell the decoder to feed branches to the thread stack, which has the > advantage that it happens before branch filtering and so can be used > with different itrace options (e.g. it still works when only showing > calls, even though the thread stack needs to see calls and returns). Also > it does not conflict with using the thread stack to get callchains. > > 2. Print "call" or "ret" instead of using a different event > > > Adrian Hunter (3): > perf: script: Fix documentation of '-f' when it should be '-F' > perf auxtrace: Add option to feed branches to the thread stack > perf script: Add callindent option > > tools/perf/Documentation/perf-script.txt | 26 +++++++----- > tools/perf/builtin-script.c | 70 ++++++++++++++++++++++++++++++++ > tools/perf/util/auxtrace.h | 2 + > tools/perf/util/intel-bts.c | 22 +++++++--- > tools/perf/util/intel-pt.c | 5 ++- > tools/perf/util/thread-stack.c | 7 ++++ > tools/perf/util/thread-stack.h | 1 + > 7 files changed, 117 insertions(+), 16 deletions(-) > > > Regards > Adrian