From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754621AbcFPUeP (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Jun 2016 16:34:15 -0400
Received: from mga04.intel.com ([192.55.52.120]:32090 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754493AbcFPUeN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Jun 2016 16:34:13 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,481,1459839600"; 
   d="scan'208";a="1003544984"
Date: Thu, 16 Jun 2016 22:34:13 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, linux-security-module@vger.kernel.org,
        Marcel Selhorst <tpmdd@selhorst.net>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        "moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@lists.sourceforge.net>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm_vtpm_proxy: fix sparse warning
Message-ID: <20160616203413.GH1414@intel.com>
References: <1466073474-4381-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <5762AC1A.8050702@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5762AC1A.8050702@linux.vnet.ibm.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 16, 2016 at 09:39:38AM -0400, Stefan Berger wrote:
> On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote:
> >When running make C=2 M=drivers/char/tpm/
> >
> >   CC [M]  drivers/char/tpm//tpm_crb.o
> >   CHECK   drivers/char/tpm//tpm_vtpm_proxy.c
> >drivers/char/tpm//tpm_vtpm_proxy.c:552:32: warning: incorrect type in assignment (different address spaces)
> >drivers/char/tpm//tpm_vtpm_proxy.c:552:32:    expected struct vtpm_proxy_new_dev *vtpm_new_dev_p
> >drivers/char/tpm//tpm_vtpm_proxy.c:552:32:    got void [noderef] <asn:1>*argp
> >drivers/char/tpm//tpm_vtpm_proxy.c:553:51: warning: incorrect type in argument 2 (different address spaces)
> >drivers/char/tpm//tpm_vtpm_proxy.c:553:51:    expected void const [noderef] <asn:1>*from
> >drivers/char/tpm//tpm_vtpm_proxy.c:553:51:    got struct vtpm_proxy_new_dev *vtpm_new_dev_p
> >drivers/char/tpm//tpm_vtpm_proxy.c:559:34: warning: incorrect type in argument 1 (different address spaces)
> >drivers/char/tpm//tpm_vtpm_proxy.c:559:34:    expected void [noderef] <asn:1>*to
> >drivers/char/tpm//tpm_vtpm_proxy.c:559:34:    got struct vtpm_proxy_new_dev *vtpm_new_dev_p
> >
> >The __user annotation was missing from the corresponding variable.
> >
> >Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> 
> PS: I get similar warnings for line 248 in tpm_crb.c.

Yup, I'll proceed to that next. Thank you.

/Jarkko