From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755042AbcFPVn6 (ORCPT ); Thu, 16 Jun 2016 17:43:58 -0400 Received: from mail-bl2nam02on0065.outbound.protection.outlook.com ([104.47.38.65]:43136 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754141AbcFPVn4 (ORCPT ); Thu, 16 Jun 2016 17:43:56 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Thu, 16 Jun 2016 14:43:46 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Daniel Lezcano CC: , , Michal Simek , "moderated list:ARM/ZYNQ ARCHITEC..." Subject: Re: [PATCH V2 07/63] clocksource/drivers/cadence_ttc: Convert init function to return error Message-ID: <20160616214346.GN19175@xsjsorenbubuntu> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-8-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1466112442-31105-8-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22394.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(377424004)(199003)(189002)(76506005)(50466002)(47776003)(86362001)(4326007)(63266004)(57986006)(106466001)(9686002)(110136002)(2906002)(356003)(586003)(4001350100001)(1076002)(85202003)(8936002)(83506001)(9786002)(19580395003)(33656002)(6806005)(77096005)(11100500001)(76176999)(189998001)(2870700001)(87936001)(2950100001)(92566002)(5008740100001)(8676002)(85182001)(36386004)(33716001)(23676002)(81156014)(50986999)(19580405001)(81166006)(54356999)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2NAM02HT106;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: c30b0946-c6c1-4500-ca22-08d3962f5045 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BL2NAM02HT106; X-Microsoft-Antispam-PRVS: <30654334454949cbbe56c4c5e38b7106@BL2NAM02HT106.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13024025)(8121501046)(13023025)(13018025)(5005006)(13017025)(3002001)(10201501046)(6055026);SRVR:BL2NAM02HT106;BCL:0;PCL:0;RULEID:;SRVR:BL2NAM02HT106; X-Forefront-PRVS: 09752BC779 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 21:43:54.1877 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT106 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-16 at 23:26:26 +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano Acked-by: Sören Brinkmann Sören