From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: [PATCH 6/6] memory: atmel-ebi: make it explicitly non-modular
Date: Thu, 16 Jun 2016 20:37:48 -0400 [thread overview]
Message-ID: <20160617003748.12188-7-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160617003748.12188-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/memory/Kconfig:config ATMEL_EBI
drivers/memory/Kconfig: bool "Atmel EBI driver"
...meaning that it currently is not being built as a module by anyone.
Lets remove the few remaining modular references, so that when reading
the driver there is no doubt it is builtin-only.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/memory/atmel-ebi.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 17d9d3f60f20..f87ad6f5d2dc 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -14,7 +14,7 @@
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/atmel-matrix.h>
#include <linux/mfd/syscon/atmel-smc.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/of_device.h>
#include <linux/regmap.h>
@@ -648,7 +648,6 @@ static const struct of_device_id at91_ebi_id_table[] = {
},
{ /* sentinel */ }
};
-MODULE_DEVICE_TABLE(of, at91_ebi_id_table);
static int at91_ebi_dev_disable(struct at91_ebi *ebi, struct device_node *np)
{
@@ -764,8 +763,4 @@ static struct platform_driver at91_ebi_driver = {
.of_match_table = at91_ebi_id_table,
},
};
-module_platform_driver_probe(at91_ebi_driver, at91_ebi_probe);
-
-MODULE_AUTHOR("Jean-Jacques Hiblot <jjhiblot@traphandler.com>");
-MODULE_DESCRIPTION("Atmel EBI driver");
-MODULE_LICENSE("GPL");
+builtin_platform_driver_probe(at91_ebi_driver, at91_ebi_probe);
--
2.8.4
next prev parent reply other threads:[~2016-06-17 0:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 0:37 [PATCH 0/6] memory: remove modular usage from non-modular drivers Paul Gortmaker
2016-06-17 0:37 ` [PATCH 1/6] memory: atmel-sdramc: make it explicitly non-modular Paul Gortmaker
2016-06-17 7:30 ` Nicolas Ferre
2016-06-21 15:17 ` Alexandre Belloni
2016-06-17 0:37 ` [PATCH 2/6] memory: mvebu-devbus: " Paul Gortmaker
2016-06-17 0:37 ` [PATCH 3/6] memory: omap-gpmc: " Paul Gortmaker
2016-06-17 7:26 ` Roger Quadros
2016-06-17 0:37 ` [PATCH 4/6] memory: tegra20-mc: " Paul Gortmaker
2016-06-17 0:37 ` [PATCH 5/6] memory: samsung/exynos-srom: " Paul Gortmaker
2016-06-20 7:50 ` Krzysztof Kozlowski
2016-06-17 0:37 ` Paul Gortmaker [this message]
2016-06-17 7:35 ` [PATCH 6/6] memory: atmel-ebi: " Nicolas Ferre
2016-06-17 7:38 ` Boris Brezillon
2016-06-21 15:18 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617003748.12188-7-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=jjhiblot@traphandler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).