From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932129AbcFQIMa (ORCPT ); Fri, 17 Jun 2016 04:12:30 -0400 Received: from mail.fireflyinternet.com ([87.106.93.118]:55596 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753942AbcFQIMY (ORCPT ); Fri, 17 Jun 2016 04:12:24 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Fri, 17 Jun 2016 09:12:18 +0100 From: Chris Wilson To: James Bottomley Cc: Daniel Vetter , intel-gfx , Rodrigo Vivi , dri-devel , linux-kernel Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Message-ID: <20160617081218.GY6754@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , James Bottomley , Daniel Vetter , intel-gfx , Rodrigo Vivi , dri-devel , linux-kernel References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466112547.2311.3.camel@HansenPartnership.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 02:29:07PM -0700, James Bottomley wrote: > On Thu, 2016-06-16 at 23:24 +0200, Daniel Vetter wrote: > > On Thu, Jun 16, 2016 at 11:15 PM, James Bottomley > > wrote: > > > On Mon, 2016-06-13 at 13:14 +0300, Jani Nikula wrote: > > > > On Tue, 31 May 2016, James Bottomley < > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > On Tue, 2016-05-31 at 10:51 +0300, Jani Nikula wrote: > > > > > > On Mon, 30 May 2016, James Bottomley < > > > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > > > I've tested a pristine 4.6.0 system, so it's definitely > > > > > > > something > > > > > > > that > > > > > > > went in during the merge window. The flicker isn't > > > > > > > continuous, > > > > > > > it's > > > > > > > periodic, with an interval of something like 2-5 seconds. > > > > > > > It > > > > > > > looks > > > > > > > like an old analogue TV going out of sync and then > > > > > > > resyncing. > > > > > > > I've > > > > > > > attached the dmesg and X.org log below just in case they > > > > > > > can > > > > > > > help. > > > > > > > I > > > > > > > might be able to bisect this next week, but, unfortunately, > > > > > > > this is > > > > > > > my > > > > > > > current laptop and I'm travelling this week. > > > > > > > > > > > > Please try i915.enable_psr=0 module parameter. > > > > > > > > > > Makes no discernable difference. Current parameter settings > > > > > are: > > > > > > > > Sorry for the silence. Would you mind trying out drm-intel > > > > -nightly > > > > branch of [1]? > > > > > > > > BR, > > > > Jani. > > > > > > > > [1] http://cgit.freedesktop.org/drm-intel > > > > > > No, flicker is still there (and in fact seems worse) with the tree > > > with > > > this commit at the top: > > > > > > commit 3eb202ecc3668583f9ff4338211dbab47d755d1c > > > Author: Daniel Vetter > > > Date: Thu Jun 16 14:38:54 2016 +0200 > > > > > > drm-intel-nightly: 2016y-06m-16d-12h-38m-37s UTC integration > > > manifest > > > > Strange indeed, I hoped the improved watermark code in -nightly would > > help. I assume nothing in dmesg about underruns or something similar? > > Not that I can tell. I've attached the full dmesg just in case. It is worth using drm.debug=0xe to get the full atomic modesetting splat. There may be a tell-tale in there that we don't yet have a warning for. -Chris > -- Chris Wilson, Intel Open Source Technology Centre