From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755357AbcFQLml (ORCPT ); Fri, 17 Jun 2016 07:42:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45494 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029AbcFQLmk (ORCPT ); Fri, 17 Jun 2016 07:42:40 -0400 Date: Fri, 17 Jun 2016 12:42:35 +0100 From: Mark Brown To: Pingbo Wen Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, vincent.guittot@linaro.org, stephen.boyd@linaro.org Message-ID: <20160617114235.GK26099@sirena.org.uk> References: <1462777508-24934-1-git-send-email-pingbo.wen@linaro.org> <20160608171608.GM7510@sirena.org.uk> <57614479.1060708@linaro.org> <20160615133255.GZ2282@sirena.org.uk> <57636FC1.3040607@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W/+CTqSGWdiRg+8j" Content-Disposition: inline In-Reply-To: <57636FC1.3040607@linaro.org> X-Cookie: news: gotcha User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH] regulator: introduce boot protection flag X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --W/+CTqSGWdiRg+8j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 17, 2016 at 11:34:25AM +0800, Pingbo Wen wrote: > On Wednesday, June 15, 2016 09:32 PM, Mark Brown wrote: > > Having the consumer driver know that it's "critical" seems wrong since > > different systems may have different ideas about that, it's probably > > better to hook this in with the device model so that when the device > > finishes probing that kicks things off. > That will imply the protection would be end when the specific device has > probed, and consumers should take their place at the same time. But > there have some other devices, which will set the consumer in a IRQ > event, or after some other events, can't be covered. I don't understand what this means, sorry. > We can set the protection flag easily, but it's hard to tell whether a > consumer is well initialized, the end of protection, since regulator > consumer is not initialized within one call. If the driver is not initializing itself during probe the driver is doing something wrong and needs to be fixed anyway. --W/+CTqSGWdiRg+8j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXY+IqAAoJECTWi3JdVIfQybEH/Ag4wHABLuUsV3kQVy8/Pzj5 /EB6kBpfeaLXkIoy4aVAkyfQet4IlurG9SEcJoO+0dOXWCvLeNn6pj8L0vt02icz jjQ5Y952mfppwqtAxSxL91Zw0vsCBdx5g8Q//cjD/7JSh2eqU3wAwWnjjKi2sk8r dALPJHSQA3dcRD3NZCpATN/xjN2vQg99Bpc4rMBUAVQxhHVMl9sweG1CkdC5LuRN FYmib9KBCe2htVO106cNGdkFbOf0XBCBeZ/1gw5HUvQHE3E+Vg3G4Xa/e5rs++vR 7imGaNZF1CnZFxE9q5rOBXpr/U3//7er1J6XzkSwGCtvR+VE01aWh9d9Gd/gP/0= =cNuV -----END PGP SIGNATURE----- --W/+CTqSGWdiRg+8j--