From: Jean-Philippe Brucker <Jean-Philippe.Brucker@arm.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, robin.murphy@arm.com,
alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org,
tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
christoffer.dall@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Bharat.Bhushan@freescale.com,
pranav.sawargaonkar@gmail.com, p.fedin@samsung.com,
iommu@lists.linux-foundation.org, julien.grall@arm.com,
yehuday@marvell.com
Subject: Re: [PATCH v10 7/9] irqchip/gicv3-its: register the MSI global doorbell
Date: Fri, 17 Jun 2016 17:33:27 +0100 [thread overview]
Message-ID: <20160617163327.GA26522@e106794-lin.localdomain> (raw)
In-Reply-To: <1465315288-5931-8-git-send-email-eric.auger@redhat.com>
Hi Eric,
On Tue, Jun 07, 2016 at 04:01:26PM +0000, Eric Auger wrote:
> This patch adds the registration of the MSI global doorbell in
> gicv3-its driver.
>
> This will allow the msi layer to iommu_map this doorbell when
> requested.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 5eb1f9e..ed9dfce 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -29,6 +29,8 @@
> #include <linux/of_platform.h>
> #include <linux/percpu.h>
> #include <linux/slab.h>
> +#include <linux/iommu.h>
> +#include <linux/msi-doorbell.h>
>
> #include <linux/irqchip.h>
> #include <linux/irqchip/arm-gic-v3.h>
> @@ -1607,6 +1609,7 @@ static int __init its_probe(struct device_node *node,
>
> if (of_property_read_bool(node, "msi-controller")) {
> struct msi_domain_info *info;
> + phys_addr_t translater;
>
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> if (!info) {
> @@ -1614,10 +1617,21 @@ static int __init its_probe(struct device_node *node,
> goto out_free_tables;
> }
>
> + translater = its->phys_base + GITS_TRANSLATER;
> + err = msi_doorbell_register_global(its, translater,
> + sizeof(u32),
> + IOMMU_WRITE | IOMMU_MMIO, true);
This doesn't work :(
First we have its_probe registering the global mapping with
doorbell->chip_data = its, which is a pointer to an its_node structure.
But when enabling MSIs for a device, its_irq_domain_alloc puts a pointer
to an *its_device* into irq_data->chip_data. This seems to be a
per-device structure, allocated by its_msi_prepare.
The following call to msi_doorbell_lookup won't ever succeed, because it
will compare its_node to its_device. I can't figure out how to fix it
cleanly at the moment.
Jean-Philippe
> + if (err) {
> + kfree(info);
> + goto out_free_tables;
> + }
> +
> +
> inner_domain = irq_domain_add_tree(node, &its_domain_ops, its);
> if (!inner_domain) {
> err = -ENOMEM;
> kfree(info);
> + msi_doorbell_unregister(its);
> goto out_free_tables;
> }
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-06-17 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 16:01 [PATCH v10 0/9] KVM PCIe/MSI passthrough on ARM/ARM64: kernel part 2/3: msi changes Eric Auger
2016-06-07 16:01 ` [PATCH v10 1/9] genirq/msi: export msi_get_domain_info Eric Auger
2016-06-07 16:01 ` [PATCH v10 2/9] genirq/msi: msi_compose wrapper Eric Auger
2016-06-07 16:01 ` [PATCH v10 3/9] genirq/msi-doorbell: creation Eric Auger
2016-06-07 16:01 ` [PATCH v10 4/9] genirq/msi-doorbell: msi_doorbell_pages Eric Auger
2016-06-07 16:01 ` [PATCH v10 5/9] genirq/msi-doorbell: msi_doorbell_safe Eric Auger
2016-06-07 16:01 ` [PATCH v10 6/9] irqchip/gicv2m: register the MSI global doorbell Eric Auger
2016-06-07 16:01 ` [PATCH v10 7/9] irqchip/gicv3-its: " Eric Auger
2016-06-17 16:33 ` Jean-Philippe Brucker [this message]
2016-06-19 16:11 ` Auger Eric
2016-06-07 16:01 ` [PATCH v10 8/9] genirq/msi: map/unmap the MSI doorbells on msi_domain_alloc/free_irqs Eric Auger
2016-06-07 16:01 ` [PATCH v10 9/9] genirq/msi: use the MSI doorbell's IOVA when requested Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617163327.GA26522@e106794-lin.localdomain \
--to=jean-philippe.brucker@arm.com \
--cc=Bharat.Bhushan@freescale.com \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=julien.grall@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=p.fedin@samsung.com \
--cc=pranav.sawargaonkar@gmail.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=yehuday@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).