From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933437AbcFQRqa (ORCPT ); Fri, 17 Jun 2016 13:46:30 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58307 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932778AbcFQRq2 (ORCPT ); Fri, 17 Jun 2016 13:46:28 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Fri, 17 Jun 2016 10:46:21 -0700 From: "Paul E. McKenney" To: Pranith Kumar Cc: LKML , Ingo Molnar , jiangshanlai@gmail.com, Dipankar Sarma , Andrew Morton , Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , Darren Hart , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Oleg Nesterov Subject: Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c to tree_exp.h Reply-To: paulmck@linux.vnet.ibm.com References: <20160615214550.GA4931@linux.vnet.ibm.com> <1466027173-5501-4-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061717-0016-0000-0000-000003FA218F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061717-0017-0000-0000-0000304D030E Message-Id: <20160617174621.GX3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-17_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606170203 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 11:48:12AM -0400, Pranith Kumar wrote: > Hi Paul, > > On Wed, Jun 15, 2016 at 5:46 PM, Paul E. McKenney > wrote: > > People have been having some difficulty finding their way around the > > RCU code. This commit therefore pulls some of the expedited grace-period > > code from tree.c to a new tree_exp.h file. This commit is strictly code > > movement, with the exception of a forward declaration that was added > > for the sync_sched_exp_online_cleanup() function. > > > > A subsequent commit will move the remaining expedited grace-period code > > from tree_plugin.h to tree_exp.h. > > > > Signed-off-by: Paul E. McKenney > > --- > > kernel/rcu/tree.c | 545 +----------------------------------------------- > > kernel/rcu/tree_exp.h | 564 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 566 insertions(+), 543 deletions(-) > > create mode 100644 kernel/rcu/tree_exp.h > > > > I've always wondered why you chose to only have a header file instead > of the traditional x.h/x.c split for declarations and > definitions(looking at tree_plugin.h). Is there any particular reason > for this? I didn't want to worry about function-call overhead, and doing it this way allowed inlining. Perhaps if link-time optimizations end up being used heavily, I should go to the usual .h/.c split. Thanx, Paul