From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014AbcFQSR2 (ORCPT ); Fri, 17 Jun 2016 14:17:28 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35506 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbcFQSR0 (ORCPT ); Fri, 17 Jun 2016 14:17:26 -0400 Date: Fri, 17 Jun 2016 14:17:24 -0400 From: Tejun Heo To: Johannes Weiner Cc: Andrew Morton , Vladimir Davydov , Michal Hocko , Li Zefan , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 2/3] cgroup: remove unnecessary 0 check from css_from_id() Message-ID: <20160617181724.GO3262@mtj.duckdns.org> References: <20160616034244.14839-1-hannes@cmpxchg.org> <20160616200617.GD3262@mtj.duckdns.org> <20160617162310.GA19084@cmpxchg.org> <20160617162427.GC19084@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617162427.GC19084@cmpxchg.org> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 12:24:27PM -0400, Johannes Weiner wrote: > css_idr allocation starts at 1, so index 0 will never point to an > item. css_from_id() currently filters that before asking idr_find(), > but idr_find() would also just return NULL, so this is not needed. > > Signed-off-by: Johannes Weiner Applied 1-2 to cgroup/for-4.8. Thanks. -- tejun