From: Bjorn Helgaas <helgaas@kernel.org>
To: Keith Busch <keith.busch@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Jon Derrick <jonathan.derrick@intel.com>
Subject: Re: [PATCH 2/2] vmd: use untracked irq handler
Date: Fri, 17 Jun 2016 18:00:52 -0500 [thread overview]
Message-ID: <20160617230052.GA21200@localhost> (raw)
In-Reply-To: <1466200821-29159-2-git-send-email-keith.busch@intel.com>
On Fri, Jun 17, 2016 at 04:00:21PM -0600, Keith Busch wrote:
> There is no way to know which device in a VMD tiggered an interrupt
s/tiggered/triggered/
> without invoking every registered driver's actions. This uses the
> untracked irq handler so that a less used device does not trigger
> spurious interrupt.
>
> We have been previously recommending users enable "noirqdebug", but do
> not want to force a system setting just to keep this domain functional.
I applaud that goal.
> Signed-off-by: Keith Busch <keith.busch@intel.com>
Since this depends on the previous patch and I'm not qualified to review
that one, I'll ack this and somebody else can merge both or none:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> arch/x86/pci/vmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c
> index 7792aba..613cac7 100644
> --- a/arch/x86/pci/vmd.c
> +++ b/arch/x86/pci/vmd.c
> @@ -195,7 +195,7 @@ static int vmd_msi_init(struct irq_domain *domain, struct msi_domain_info *info,
> vmdirq->virq = virq;
>
> irq_domain_set_info(domain, virq, vmdirq->irq->vmd_vector, info->chip,
> - vmdirq, handle_simple_irq, vmd, NULL);
> + vmdirq, handle_untracked_irq, vmd, NULL);
> return 0;
> }
>
> --
> 2.7.2
>
next prev parent reply other threads:[~2016-06-17 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 22:00 [PATCH 1/2] irq: Add untracked irq handler Keith Busch
2016-06-17 22:00 ` [PATCH 2/2] vmd: use " Keith Busch
2016-06-17 23:00 ` Bjorn Helgaas [this message]
2016-06-18 8:07 ` [tip:irq/core] x86/PCI/VMD: Use " tip-bot for Keith Busch
2016-06-18 8:07 ` [tip:irq/core] genirq: Add " tip-bot for Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617230052.GA21200@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).