From: Wolfram Sang <wsa@the-dreams.de>
To: Austin Christ <austinwc@codeaurora.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, rruigrok@codeaurora.org,
timur@codeaurora.org, cov@codeaurora.org, nkaje@codeaurora.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] i2c: qup: support SMBus block read
Date: Sat, 18 Jun 2016 16:13:28 +0200 [thread overview]
Message-ID: <20160618141328.GC1430@tetsubishi> (raw)
In-Reply-To: <1465409985-17113-2-git-send-email-austinwc@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Wed, Jun 08, 2016 at 12:19:45PM -0600, Austin Christ wrote:
> From: Naveen Kaje <nkaje@codeaurora.org>
>
> I2C QUP driver relies on SMBus emulation support from the framework.
> To handle SMBus block reads, the driver should check I2C_M_RECV_LEN
> flag and should read the first byte received as the message length.
>
> The driver configures the QUP hardware to read one byte. Once the
> message length is known from this byte, the QUP hardware is configured
> to read the rest.
>
> Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
> Signed-off-by: Austin Christ <austinwc@codeaurora.org>
> Reviewed-by: sricharan@codeaurora.org
Missing name here, too. Looks good otherwise.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-18 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 18:19 [PATCH v4 1/2] i2c: qup: add ACPI support Austin Christ
2016-06-08 18:19 ` [PATCH v4 2/2] i2c: qup: support SMBus block read Austin Christ
2016-06-18 14:13 ` Wolfram Sang [this message]
2016-06-08 21:02 ` [PATCH v4 1/2] i2c: qup: add ACPI support Arnd Bergmann
2016-06-30 11:35 ` Christopher Covington
2016-06-30 11:52 ` Arnd Bergmann
2016-06-30 18:50 ` Christopher Covington
2016-07-01 9:57 ` Arnd Bergmann
2016-06-09 13:51 ` kbuild test robot
2016-06-18 14:10 ` Wolfram Sang
2016-06-20 8:24 ` Mika Westerberg
2016-06-20 15:00 ` Timur Tabi
2016-06-20 15:07 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160618141328.GC1430@tetsubishi \
--to=wsa@the-dreams.de \
--cc=austinwc@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nkaje@codeaurora.org \
--cc=rruigrok@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).