From: Minchan Kim <minchan@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Jerome Marchand <jmarchan@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MADVISE_FREE, THP: Fix madvise_free_huge_pmd return value after splitting
Date: Mon, 20 Jun 2016 09:15:19 +0900 [thread overview]
Message-ID: <20160620001519.GC3194@blaptop> (raw)
In-Reply-To: <87mvmjha54.fsf@yhuang-mobile.sh.intel.com>
On Fri, Jun 17, 2016 at 12:45:43PM -0700, Huang, Ying wrote:
> Minchan Kim <minchan@kernel.org> writes:
>
> > Hi,
> >
> > On Thu, Jun 16, 2016 at 08:03:54PM -0700, Huang, Ying wrote:
> >> From: Huang Ying <ying.huang@intel.com>
> >>
> >> madvise_free_huge_pmd should return 0 if the fallback PTE operations are
> >> required. In madvise_free_huge_pmd, if part pages of THP are discarded,
> >> the THP will be split and fallback PTE operations should be used if
> >> splitting succeeds. But the original code will make fallback PTE
> >> operations skipped, after splitting succeeds. Fix that via make
> >> madvise_free_huge_pmd return 0 after splitting successfully, so that the
> >> fallback PTE operations will be done.
> >
> > You're right. Thanks!
> >
> >>
> >> Know issues: if my understanding were correct, return 1 from
> >> madvise_free_huge_pmd means the following processing for the PMD should
> >> be skipped, while return 0 means the following processing is still
> >> needed. So the function should return 0 only if the THP is split
> >> successfully or the PMD is not trans huge. But the pmd_trans_unstable
> >> after madvise_free_huge_pmd guarantee the following processing will be
> >> skipped for huge PMD. So current code can run properly. But if my
> >> understanding were correct, we can clean up return code of
> >> madvise_free_huge_pmd accordingly.
> >
> > I like your clean up. Just a minor comment below.
> >
> >>
> >> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> >> ---
> >> mm/huge_memory.c | 7 +------
> >> 1 file changed, 1 insertion(+), 6 deletions(-)
> >>
> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> >> index 2ad52d5..64dc95d 100644
> >> --- a/mm/huge_memory.c
> >> +++ b/mm/huge_memory.c
> >
> > First of all, let's change ret from int to bool.
> > And then, add description in the function entry.
>
> Yes. bool looks better than int.
>
> > /*
> > * Return true if we do MADV_FREE successfully on entire pmd page.
> > * Otherwise, return false.
> > */
>
> This way, we need to return false if we failed to split huge page, this
> will cause unnecessary pmd_trans_unstable check. How about to change
> the comments to
I focused the function name "madvise_free_huge_pmd". IOW, the function
should free huge pmd page. If it is successful, done. Otherwise, next
routines should handle it.
If it fail to split, pmd_trans_unstable will check it and return.
I don't think it's heavy operation to affect performance so rather
than making function fast, I wanted to make it simple by following
function name.
>
> /*
> * Return true if we finished processing entire pmd page and needn't
> * fall back pte processing. Otherwise, return false.
> */
>
> Best Regards,
> Huang, Ying
>
> > And do not set to 1 if it is huge_zero_pmd but just goto out to
> > return false.
> >
> > Thanks!
> >
> >> @@ -1655,14 +1655,9 @@ int madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
> >> if (next - addr != HPAGE_PMD_SIZE) {
> >> get_page(page);
> >> spin_unlock(ptl);
> >> - if (split_huge_page(page)) {
> >> - put_page(page);
> >> - unlock_page(page);
> >> - goto out_unlocked;
> >> - }
> >> + split_huge_page(page);
> >> put_page(page);
> >> unlock_page(page);
> >> - ret = 1;
> >> goto out_unlocked;
> >> }
> >>
> >> --
> >> 2.8.1
> >>
> >> --
> >> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> >> the body to majordomo@kvack.org. For more info on Linux MM,
> >> see: http://www.linux-mm.org/ .
> >> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-20 1:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 3:03 [PATCH] MADVISE_FREE, THP: Fix madvise_free_huge_pmd return value after splitting Huang, Ying
2016-06-17 3:15 ` Huang, Ying
2016-06-17 5:31 ` Minchan Kim
2016-06-17 15:59 ` Huang, Ying
2016-06-19 23:54 ` Minchan Kim
2016-06-20 15:48 ` Huang, Ying
2016-06-17 19:45 ` Huang, Ying
2016-06-20 0:15 ` Minchan Kim [this message]
2016-06-20 15:48 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620001519.GC3194@blaptop \
--to=minchan@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebru.akagunduz@gmail.com \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).