From: Bin Gao <bin.gao@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org, ysiyer <yegnesh.s.iyer@intel.com>,
Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
Bin Gao <bin.gao@intel.com>,
broonie@kernel.org
Subject: Re: [PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping
Date: Sun, 19 Jun 2016 21:11:40 -0700 [thread overview]
Message-ID: <20160620041140.GA237834@worksta> (raw)
In-Reply-To: <20160617080159.GF21702@dell>
On Fri, Jun 17, 2016 at 09:01:59AM +0100, Lee Jones wrote:
> > +static struct trip_config_map str0_trip_config[] = {
> > + {
> > + .irq_reg = BXTWC_THRM0IRQ,
> > + .irq_mask = 0x01,
> > + .irq_en = BXTWC_MTHRM0IRQ,
> > + .irq_en_mask = 0x01,
> > + .evt_stat = BXTWC_STHRM0IRQ,
> > + .evt_mask = 0x01,
> > + .trip_num = 0
> > + },
> > + {
> > + .irq_reg = BXTWC_THRM0IRQ,
> > + .irq_mask = 0x10,
> > + .irq_en = BXTWC_MTHRM0IRQ,
> > + .irq_en_mask = 0x10,
> > + .evt_stat = BXTWC_STHRM0IRQ,
> > + .evt_mask = 0x10,
> > + .trip_num = 1
> > + }
> > +};
> > +
> > +static struct trip_config_map str1_trip_config[] = {
> > + {
> > + .irq_reg = BXTWC_THRM0IRQ,
> > + .irq_mask = 0x02,
> > + .irq_en = BXTWC_MTHRM0IRQ,
> > + .irq_en_mask = 0x02,
> > + .evt_stat = BXTWC_STHRM0IRQ,
> > + .evt_mask = 0x02,
> > + .trip_num = 0
> > + },
> > + {
> > + .irq_reg = BXTWC_THRM0IRQ,
> > + .irq_mask = 0x20,
> > + .irq_en = BXTWC_MTHRM0IRQ,
> > + .irq_en_mask = 0x20,
> > + .evt_stat = BXTWC_STHRM0IRQ,
> > + .evt_mask = 0x20,
> > + .trip_num = 1
> > + },
> > +};
> > +
> > +static struct trip_config_map str2_trip_config[] = {
> > + {
> > + .irq_reg = BXTWC_THRM0IRQ,
> > + .irq_mask = 0x04,
> > + .irq_en = BXTWC_MTHRM0IRQ,
> > + .irq_en_mask = 0x04,
> > + .evt_stat = BXTWC_STHRM0IRQ,
> > + .evt_mask = 0x04,
> > + .trip_num = 0
> > + },
> > + {
> > + .irq_reg = BXTWC_THRM0IRQ,
> > + .irq_mask = 0x40,
> > + .irq_en = BXTWC_MTHRM0IRQ,
> > + .irq_en_mask = 0x40,
> > + .evt_stat = BXTWC_STHRM0IRQ,
> > + .evt_mask = 0x40,
> > + .trip_num = 1
> > + },
> > +};
> > +
> > +static struct trip_config_map str3_trip_config[] = {
> > + {
> > + .irq_reg = BXTWC_THRM2IRQ,
> > + .irq_mask = 0x10,
> > + .irq_en = BXTWC_MTHRM2IRQ,
> > + .irq_en_mask = 0x10,
> > + .evt_stat = BXTWC_STHRM2IRQ,
> > + .evt_mask = 0x10,
> > + .trip_num = 0
> > + },
> > +};
>
> This looks like a register map to me.
>
> Can you use the regmap framework instead?
These are platform data used by another driver(thermal driver) which
uses regmap framework to access some of the fields of the structure(
irq_reg, irq_en and evt_stat).
next prev parent reply other threads:[~2016-06-20 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 21:58 [PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping Bin Gao
2016-06-17 8:01 ` Lee Jones
2016-06-20 4:11 ` Bin Gao [this message]
2016-06-20 8:49 ` Lee Jones
2016-06-20 8:52 ` Lee Jones
2016-06-20 18:11 ` Bin Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620041140.GA237834@worksta \
--to=bin.gao@linux.intel.com \
--cc=ajay.thomas.david.rajamanickam@intel.com \
--cc=bin.gao@intel.com \
--cc=broonie@kernel.org \
--cc=edubezval@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=yegnesh.s.iyer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).