From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188AbcFTNHj (ORCPT ); Mon, 20 Jun 2016 09:07:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:40162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbcFTNG6 (ORCPT ); Mon, 20 Jun 2016 09:06:58 -0400 Date: Mon, 20 Jun 2016 16:04:22 +0300 From: Leon Romanovsky To: "Wei Hu (Xavier)" Cc: Lijun Ou , dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v10 08/22] IB/hns: Add icm support Message-ID: <20160620130422.GA4526@leon.nu> Reply-To: leon@kernel.org References: <1466087730-54856-1-git-send-email-oulijun@huawei.com> <1466087730-54856-9-git-send-email-oulijun@huawei.com> <20160617095834.GA5408@leon.nu> <57677314.70909@huawei.com> <20160620060614.GC1172@leon.nu> <5767A004.4060808@huawei.com> <20160620092719.GE1172@leon.nu> <5767BBDF.6010309@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline In-Reply-To: <5767BBDF.6010309@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: >=20 >=20 > On 2016/6/20 17:27, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 14:06, Leon Romanovsky wrote: > >>>On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > >>>>On 2016/6/17 17:58, Leon Romanovsky wrote: > >>>>>On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > >>>>>>This patch mainly added icm support for RoCE. It initializes icm > >>>>>>which managers the relative memory blocks for RoCE. The data > >>>>>>structures of RoCE will be located in it. For example, CQ table, > >>>>>>QP table and MTPT table so on. > >>>>>> > >>>>>>Signed-off-by: Wei Hu > >>>>>>Signed-off-by: Nenglong Zhao > >>>>>>Signed-off-by: Lijun Ou > >>>>>>--- > >>>>><...> > >>>>> > >>>>>>+ > >>>Another question which you didn't answer [1]. > >>> > >>>"I wonder if you have the same needs for ICM as it is in mlx4 device. > >>>Do you have firmware?" > >>> > >>>[1] http://marc.info/?l=3Dlinux-rdma&m=3D146545553104913&w=3D2 > >>Hi, Leon > >> Now we haven't firmware. > >> But hardware still need memory for QPC\CQC\MTPT\mtt etc. > >ICM stands for InfiniHost (Interconnect) Context Memory is a specific > >memory place to share between host <-> FW and host <-> HW if HW is > >aware of specific structures. > > > >I assume that in your case, it is enough to allocate memory region and > >supply it to HW. Am I right? > For Our hardware, > 1. ICM has a memory management method, It's very good for QPC\CQC\MTPT\mtt > etc. we need it. You need special HW to leverage its. AFAIK it is Mellanox specific. > 2. The meomry for QPC\CQC\MTPT\mtt only used for RoCE hardware and driver, > we don't want use MR. I didn't mean Infiniband MR, but memory region returned from standard allocation functions (kmalloc, ...). > 3. Now we haven't firmware, maybe we need it next version. You are always invited to add support once it will be needed, no need to add it in advance. Thanks --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXZ+nWAAoJEORje4g2clinS94P/0GGhGBG/WNmJyPJSDgPQF5X jz3r+CYHMi/6LZdSx2cqejzNdNuc2Z8xb4jn1XRl/WxMQEUIQZbFDLS+12Sv+HBT Z34fpyeyEeqSi/tU/FwcZn83hKluROboOlnbD1nvOjxbrzPICuOi0+EYvJnb2GVo dia8Gp6i2H1KWLCSD92z+aksbGYQ/5f2nimMX/J07/tXDzs1arcc1YOoJdMkL3yd JGsGd8IOVu2+TkQBdLlsKl3OMJz5lFaLjfH4xHZKjmLm9WXC3QCPAyOGZHoSDurY 5G6eOxRcj/IHIRt0B+JqxCCyV8ojkqey2hjX7V3xhRNyKQEiLVxaacMpGqF80X14 Qza1q7OiOkU5NqJ1hyB5MriSkgydYRhXyo+S66kP1JMmmcGKYQWfJ0wVKDpumJt3 9uivy6wSTN16GvIlxeMOj7TgbPOdKLhLV5/GAGLcwm5mgR/p5CqUfTZtfoiH8T3A EjI1dVmJunnPwHqzkWKiZq0PjJknVDIET8/U3sdhJvMVBXzyF53Y+VQNG/YHG5NJ aEb4ktGc12wjDxpIfWWtnN0OWWctfoNdiW2u3Uzk36WLZA1HGZGVmlGn6K2dzm+y 0++w+//yXJ2FKrMg1xALIefEbo5RcZ98ElZmiVMXHgnTQdyeTXEmzXmHQdeB+Qbh KdS53oyC86E6Sa2bl4zp =KFG/ -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--