From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932361AbcFTNeD (ORCPT ); Mon, 20 Jun 2016 09:34:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:45144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752001AbcFTNdz (ORCPT ); Mon, 20 Jun 2016 09:33:55 -0400 Date: Mon, 20 Jun 2016 16:33:10 +0300 From: Leon Romanovsky To: Lijun Ou Cc: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation Message-ID: <20160620133310.GB4526@leon.nu> Reply-To: leon@kernel.org References: <1466087730-54856-1-git-send-email-oulijun@huawei.com> <1466087730-54856-7-git-send-email-oulijun@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CdrF4e02JqNVZeln" Content-Disposition: inline In-Reply-To: <1466087730-54856-7-git-send-email-oulijun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CdrF4e02JqNVZeln Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: > This patch added the operation for cmd, and added some functions > for initializing eq table and selecting cmd mode. >=20 > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao > Signed-off-by: Lijun Ou > --- > PATCH v9/v8/v7/v6: > - No change over the PATCH v5 >=20 > PATCH v5: > - The initial patch which was redesigned based on the second patch > in PATCH v4 > --- <...> > +#define CMD_MAX_NUM 32 > + > +int hns_roce_cmd_init(struct hns_roce_dev *hr_dev) > +{ > + struct device *dev =3D &hr_dev->pdev->dev; > + > + mutex_init(&hr_dev->cmd.hcr_mutex); > + sema_init(&hr_dev->cmd.poll_sem, 1); > + hr_dev->cmd.use_events =3D 0; > + hr_dev->cmd.toggle =3D 1; > + hr_dev->cmd.max_cmds =3D CMD_MAX_NUM; <...> > + for (hr_cmd->token_mask =3D 1; hr_cmd->token_mask < hr_cmd->max_cmds; > + hr_cmd->token_mask <<=3D 1) > + ; > + --hr_cmd->token_mask; It doesn't look that you dynamically change max_cmds supported. Why do you need to calculate token_mask dynamically? --CdrF4e02JqNVZeln Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXZ/CWAAoJEORje4g2clin6fYP/3irrJtA/mvfhiD+6U3rDRoN 9p5rvft5GKojFbqPNLaG7XrlKDpTgRhVVuyzjlxWSk0/P+XmdXBiRaUPESfeRf5d fPaqJQ5LP1tyo1i24c9lla7ZIUFPvdd7kKWZrP2CdqlJAgqJ2ZNuuqoP3k2gq8OT VE8zMH5INdwBoq3av5iUdJKGLSlV0YlOFOdJALjjkYelCIsy9WWVA7rJ6YXqzscG 3V/D5T6JmHP4EoD7kbaExF7SknE9kOzESjMWH1BpG00hCl0yicaPy4Ftk3vu0IU+ pyYf+moyhExcBwlNpXWejuXzfFtgygTs5+vbXu20bvHY9xhjOa3GI+Qbotk7GdHV 3KNfjsjttsoFozd8jKV6RqvywnY2f6iT1E9xNtiDJZ2g00EWrm+CdAYbz8jzbSpm UsLkzZ/5Lqv2NzW4fcP1PQNadjefowcZV6DL5mmsfSKt1if9SKIE6K9n/hUr8iy3 vC+hV7iNSSr5skDrzQ++6+OOKA28xse8cV6eeuv0uxgh1xeF1c8ZHp175AC636fW Ti0C2AFZA6c/j2oSLz+2s13t5PVTZOPh3Z3voGQRDnzD95u9AEVb2VasGD0Ko95E sb6yoqSpE3PNiNA7Ga7gK72b3JUG/Bc2jhT0zaN46Bbmaue0a52Zq2dmvbPSi6OK lYd6HEGV4qjptp4UP3kI =yDFm -----END PGP SIGNATURE----- --CdrF4e02JqNVZeln--