From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605AbcFTPCu (ORCPT ); Mon, 20 Jun 2016 11:02:50 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:34634 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbcFTPCf (ORCPT ); Mon, 20 Jun 2016 11:02:35 -0400 Date: Mon, 20 Jun 2016 11:01:44 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtip32xx: Remove deprecated create_workqueue Message-ID: <20160620150144.GU3262@mtj.duckdns.org> References: <20160618082205.GA6234@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160618082205.GA6234@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 18, 2016 at 01:52:05PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workqueue isr_workq is > involved in irq handling path of block driver and requires forward > progress under memory pressure. Hence, WQ_MEM_RECLAIM has been set. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. Hence the calls to flush_workqueue() before > destroy_workqueue() have been dropped. Looks good. Thanks! -- tejun