From: Rob Herring <robh@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802
Date: Mon, 20 Jun 2016 11:39:47 -0500 [thread overview]
Message-ID: <20160620163947.GA27492@rob-hp-laptop> (raw)
In-Reply-To: <1466160667-28451-3-git-send-email-ldewangan@nvidia.com>
On Fri, Jun 17, 2016 at 04:21:05PM +0530, Laxman Dewangan wrote:
> The clock IP used on the Maxim PMICs max77686 and max77802 are
> same. The configuration of clock register is also same except
> the number of clocks.
>
> Define the common DT binding file for the clocks of Maxim PMICs
> MAX77686 and MAX77802. For this, remove the separate DT binding
> document file for maxim,max77802 and move all information to
> maxim,max77686 DT binding document.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@dowhile0.org>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> Changes from V1:
> - Rewrite description to remvoe ref to driver.
> - Taken care of comment from Krzysztof on the supported clocks and
> DT bindings.
>
> Changes from V2:
> - Collected RBs.
> ---
> .../devicetree/bindings/clock/maxim,max77686.txt | 82 ++++++++++++++++------
> .../devicetree/bindings/clock/maxim,max77802.txt | 44 ------------
> 2 files changed, 59 insertions(+), 67 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt
>
> diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> index 9c40739..4d973b5 100644
> --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> @@ -1,11 +1,15 @@
> -Binding for Maxim MAX77686 32k clock generator block
> +Binding for Maxim MAX77686/MAX77802 32k clock generator block
>
> -This is a part of device tree bindings of MAX77686 multi-function device.
> -More information can be found in bindings/mfd/max77686.txt file.
> +This is a part of device tree bindings of MAX77686/MAX77802 multi-function
> +device. More information can be found in bindings/mfd/max77686.txt file for
> +MAX77686 and bindings/mfd/max77802.txt for MAX77802.
>
> The MAX77686 contains three 32.768khz clock outputs that can be controlled
> (gated/ungated) over I2C.
>
> +The MAX77802 contains two 32.768khz clock outputs that can be controlled
> +(gated/ungated) over I2C.
> +
> Following properties should be presend in main device node of the MFD chip.
>
> Required properties:
I'd expect to see compatible strings updated...
> @@ -17,30 +21,62 @@ Optional properties:
next prev parent reply other threads:[~2016-06-20 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 10:51 [PATCH V3 0/4] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan
2016-06-17 10:51 ` [PATCH V3 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan
2016-08-15 22:40 ` Stephen Boyd
2016-06-17 10:51 ` [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan
2016-06-20 16:39 ` Rob Herring [this message]
2016-06-21 6:46 ` Laxman Dewangan
2016-06-28 11:28 ` Laxman Dewangan
2016-08-10 9:40 ` Laxman Dewangan
2016-08-10 12:43 ` Rob Herring
2016-08-15 22:40 ` Stephen Boyd
2016-06-17 10:51 ` [PATCH V3 3/4] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan
2016-06-20 16:41 ` Rob Herring
2016-08-15 22:40 ` Stephen Boyd
2016-06-17 10:51 ` [PATCH V3 4/4] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan
2016-08-15 22:40 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620163947.GA27492@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).