From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, john.stultz@linaro.org,
arnd@arndb.de, k.kozlowski@samsung.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, dbaryshkov@gmail.com,
sre@kernel.org, matthias.bgg@gmail.com, linux-pm@vger.kernel.org,
mbrugger@suse.com, lorenzo.pieralisi@arm.com,
moritz.fischer@ettus.com, richard@nod.at
Subject: Re: [PATCH v9 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node
Date: Mon, 20 Jun 2016 14:55:46 -0700 [thread overview]
Message-ID: <20160620215545.GE1256@tuxbot> (raw)
In-Reply-To: <1466404769-3534-1-git-send-email-andy.yan@rock-chips.com>
On Sun 19 Jun 23:39 PDT 2016, Andy Yan wrote:
> Rockchip platform use a SYSCON mapped register store
> the reboot mode magic value for bootloader to use when
> system reboot. So add syscon-reboot-mode driver DT node
> for rk3xxx/rk3036/rk3288 based platform
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
[..]
> diff --git a/include/dt-bindings/soc/rockchip_boot-mode.h b/include/dt-bindings/soc/rockchip_boot-mode.h
> new file mode 100644
> index 0000000..ae7c867
> --- /dev/null
> +++ b/include/dt-bindings/soc/rockchip_boot-mode.h
> @@ -0,0 +1,15 @@
> +#ifndef __ROCKCHIP_BOOT_MODE_H
> +#define __ROCKCHIP_BOOT_MODE_H
> +
> +/*high 24 bits is tag, low 8 bits is type*/
> +#define REBOOT_FLAG 0x5242C300
> +/* normal boot */
> +#define BOOT_NORMAL (REBOOT_FLAG + 0)
> +/* enter bootloader rockusb mode */
> +#define BOOT_BL_DOWNLOAD (REBOOT_FLAG + 1)
> +/* enter recovery */
> +#define BOOT_RECOVERY (REBOOT_FLAG + 3)
> + /* enter fastboot mode */
> +#define BOOT_FASTBOOT (REBOOT_FLAG + 9)
The names of these defines are too generic for being in a header file.
You should likely make them include "ROCKCHIP" and "BOOT_MODE".
Regards,
Bjorn
next prev parent reply other threads:[~2016-06-20 22:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 6:34 [PATCH v9 0/4] add reboot mode driver Andy Yan
2016-06-20 6:36 ` [PATCH v9 1/4] dt-bindings: power: reset: add document for reboot-mode driver Andy Yan
2016-06-20 6:38 ` [PATCH v9 2/4] power: reset: add reboot mode driver Andy Yan
2016-06-20 8:09 ` Krzysztof Kozlowski
2016-06-20 8:28 ` Andy Yan
2016-06-20 12:31 ` Krzysztof Kozlowski
2016-06-20 14:40 ` Paul Gortmaker
2016-06-21 6:16 ` Andy Yan
2016-06-21 9:32 ` Krzysztof Kozlowski
2016-07-06 13:39 ` Krzysztof Kozlowski
2016-06-20 6:39 ` [PATCH v9 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node Andy Yan
2016-06-20 21:55 ` Bjorn Andersson [this message]
2016-06-21 6:08 ` Andy Yan
2016-06-20 6:40 ` [PATCH v9 4/4] ARM64: " Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620215545.GE1256@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=john.stultz@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=moritz.fischer@ettus.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).