From: Mike Snitzer <snitzer@redhat.com>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"sandeen@redhat.com" <sandeen@redhat.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"agk@redhat.com" <agk@redhat.com>
Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices
Date: Mon, 20 Jun 2016 18:22:36 -0400 [thread overview]
Message-ID: <20160620222236.GA22461@redhat.com> (raw)
In-Reply-To: <1466457467.3504.249.camel@hpe.com>
On Mon, Jun 20 2016 at 5:28pm -0400,
Kani, Toshimitsu <toshi.kani@hpe.com> wrote:
> On Mon, 2016-06-20 at 14:01 -0600, Kani, Toshimitsu wrote:
> > On Mon, 2016-06-20 at 15:52 -0400, Mike Snitzer wrote:
> > >
> > > On Mon, Jun 20 2016 at 3:40pm -0400,
> > > Mike Snitzer <snitzer@redhat.com> wrote:
> > >
> :
> > > > If I don't use XFS, and only issue IO directly to the /dev/pmem/lv, I
> > > > don't see this corruption.
> > >
> > > I did the same test with ext4 instead of xfs and it resulted in the same
> > > type of systemic corruption (lvm2 metadata corrupted too):
> > >
> :
> > I will look into the issue.
>
> Hi Mike,
>
> Can you fold the following patch to the dm-linear patch?
>
> Thanks,
> -Tsohi
>
> ------
> Subject: [PATCH] dm-linear: Fix partition handling for DAX
>
> Partition handling was missing in linear_direct_access().
> Call bdev_direct_access(), instead of directly calling
> target direct_access function.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> ---
> drivers/md/dm-linear.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
> index 325aa06..38323e4 100644
> --- a/drivers/md/dm-linear.c
> +++ b/drivers/md/dm-linear.c
> @@ -148,10 +148,16 @@ static long linear_direct_access(struct dm_target *ti,
> sector_t sector,
> {
> struct linear_c *lc = ti->private;
> struct block_device *bdev = lc->dev->bdev;
> - const struct block_device_operations *bd_ops = bdev->bd_disk->fops;
> -
> - return bd_ops->direct_access(bdev, linear_map_sector(ti, sector),
> - kaddr, pfn, size);
> + struct blk_dax_ctl dax = {
> + .sector = linear_map_sector(ti, sector),
> + .size = size,
> + };
> + long ret;
> +
> + ret = bdev_direct_access(bdev, &dax);
> + *kaddr = dax.addr;
> + *pfn = dax.pfn;
> + return ret;
> }
>
> static struct target_type linear_target = {
Looks good, I folded it in and tested it to work. Pushed to my 'wip'
branch.
No longer seeing any corruption in my test that was using partitions to
span pmem devices with a dm-linear device.
Jens, any chance you'd be open to picking up the first 2 patches in this
series? Or would you like to see them folded or something different?
Mike
next prev parent reply other threads:[~2016-06-20 22:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 22:21 [PATCH 0/6] Support DAX for device-mapper dm-linear devices Toshi Kani
2016-06-13 22:21 ` [PATCH 1/6] genhd: Add GENHD_FL_DAX to gendisk flags Toshi Kani
2016-06-13 22:21 ` [PATCH 2/6] block: Check GENHD_FL_DAX for DAX capability Toshi Kani
2016-06-13 22:21 ` [PATCH 3/6] dm: Add dm_blk_direct_access() for mapped device Toshi Kani
2016-06-13 22:21 ` [PATCH 4/6] dm-linear: Add linear_direct_access() Toshi Kani
2016-06-13 22:21 ` [PATCH 5/6] dm, dm-linear: Add dax_supported to dm_target Toshi Kani
2016-06-13 22:21 ` [PATCH 6/6] dm: Enable DAX support for mapper device Toshi Kani
2016-06-13 22:57 ` [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer
2016-06-20 18:00 ` Mike Snitzer
2016-06-20 18:31 ` Kani, Toshimitsu
2016-06-20 19:40 ` Mike Snitzer
2016-06-20 19:52 ` Mike Snitzer
2016-06-20 20:11 ` Kani, Toshimitsu
2016-06-20 21:28 ` Kani, Toshimitsu
2016-06-20 22:22 ` Mike Snitzer [this message]
2016-06-21 13:41 ` Mike Snitzer
2016-06-21 15:44 ` Kani, Toshimitsu
2016-06-21 15:50 ` Kani, Toshimitsu
2016-06-21 16:25 ` Dan Williams
2016-06-21 16:35 ` Kani, Toshimitsu
2016-06-21 16:45 ` Dan Williams
2016-06-21 16:56 ` Kani, Toshimitsu
2016-06-21 18:17 ` Mike Snitzer
2016-06-22 17:44 ` Kani, Toshimitsu
2016-06-22 19:15 ` Dan Williams
2016-06-22 20:16 ` Kani, Toshimitsu
2016-06-22 22:38 ` Mike Snitzer
2016-06-22 22:59 ` Kani, Toshimitsu
2016-06-13 23:18 ` Dan Williams
2016-06-13 23:59 ` Kani, Toshimitsu
2016-06-14 0:02 ` Dan Williams
2016-06-14 7:30 ` Dan Williams
2016-06-14 13:50 ` Jeff Moyer
2016-06-14 15:41 ` Mike Snitzer
2016-06-14 18:00 ` Kani, Toshimitsu
2016-06-14 20:19 ` Jeff Moyer
2016-06-15 1:46 ` Mike Snitzer
2016-06-15 2:07 ` Dan Williams
2016-06-15 2:35 ` Mike Snitzer
2016-06-14 15:53 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620222236.GA22461@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=sandeen@redhat.com \
--cc=toshi.kani@hpe.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).