From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378AbcFTWxA (ORCPT ); Mon, 20 Jun 2016 18:53:00 -0400 Received: from mga01.intel.com ([192.55.52.88]:52015 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932256AbcFTWws (ORCPT ); Mon, 20 Jun 2016 18:52:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,501,1459839600"; d="scan'208";a="1001881552" Date: Mon, 20 Jun 2016 18:54:45 -0400 From: Keith Busch To: Jethro Beekman Cc: axboe@fb.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] nvme: Don't add namespaces for locked drives Message-ID: <20160620225444.GB1448@localhost.localdomain> References: <20160619230634.17229-1-kernel@jbeekman.nl> <20160620152639.GD12936@localhost.localdomain> <57683415.1060202@jbeekman.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57683415.1060202@jbeekman.nl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 11:21:09AM -0700, Jethro Beekman wrote: > On 20-06-16 08:26, Keith Busch wrote: > > Would this just be a matter of setting req->retries and checking for it in > nvme_req_needs_retry? How does one keep track of the number of tries so far? I just sent a patch out earlier today to use req->retries to track the retry count, and nvme module parameter to set the max retries. I think that would fix the long delays you're seeing, assuming the patch is okay. > You're right, I assumed that admin commands can't have namespace ids, but > looking at the spec, that's not the case. Turns out there's a problem with the > driver then: nvme_ioctl never includes the ns for NVME_IOCTL_ADMIN_CMD. The NVME_IOCTL_ADMIN_CMD already takes any namespace identifier the user put in that field.