From: Stephen Boyd <sboyd@codeaurora.org>
To: Jongsung Kim <neidhard.kim@lge.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Chanho Min <chanho.min@lge.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [RESEND][PATCH] clk: fixed-factor: set CLK_SET_RATE_PARENT
Date: Mon, 20 Jun 2016 17:59:10 -0700 [thread overview]
Message-ID: <20160621005910.GN1521@codeaurora.org> (raw)
In-Reply-To: <1465808880-12332-1-git-send-email-neidhard.kim@lge.com>
On 06/13, Jongsung Kim wrote:
> Without CLK_SET_RATE_PARENT-flag set, clk_factor_round_rate() just
> returns the current frequency. A fixed-factor-clock initialzed via
> of_fixed_factor_clk_set() (ie, by device-tree) can't have the flag
> set. It can be problematic when the parent of a fixed-factor-clock
> is rate-controllable clk, because the rounding can't be propagated
> to parent, the rounded target frequency is always the current, and
> finally the frequency can't be changed.
>
> This patch sets the flags CLK_SET_RATE_PARENT for all fixed-factor-
> clocks, from clk_register_fixed_factor(), and removes checking the
> flag from clk_factor_round_rate().
>
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
> ---
Hmm there's another patch for the same problem from Maxime[1]
Mike replied there and said that it's worrisome to do this for
all users of fixed factors clks, so perhaps you can set this flag
when you register the clk instead? Or prove that all the users of
this code in mainline are ok to change behavior.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/429726.html
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-06-21 0:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:08 [RESEND][PATCH] clk: fixed-factor: set CLK_SET_RATE_PARENT Jongsung Kim
2016-06-21 0:59 ` Stephen Boyd [this message]
2016-06-24 3:49 ` [PATCH] clk: fixed-factor: add optional dt-binding clock-flags Jongsung Kim
2016-06-24 5:11 ` kbuild test robot
2016-06-24 5:57 ` kbuild test robot
2016-06-24 4:12 ` [PATCH v2] " Jongsung Kim
2016-06-28 20:55 ` Rob Herring
2016-06-28 21:18 ` Michael Turquette
2016-06-29 7:06 ` Jongsung Kim
2016-07-02 0:20 ` Stephen Boyd
2016-07-04 1:48 ` Jongsung Kim
2016-08-25 0:52 ` Stephen Boyd
2016-06-29 5:04 ` Jongsung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621005910.GN1521@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=chanho.min@lge.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=neidhard.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).