From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbcFUBP7 (ORCPT ); Mon, 20 Jun 2016 21:15:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52716 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754547AbcFUBPt (ORCPT ); Mon, 20 Jun 2016 21:15:49 -0400 Date: Mon, 20 Jun 2016 18:15:37 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Mike Turquette , Chen-Yu Tsai , linux-clk@vger.kernel.org, Hans de Goede , Andre Przywara , Rob Herring , Vishnu Patekar , linux-arm-kernel@lists.infradead.org, Boris Brezillon , Jean-Francois Moine , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support Message-ID: <20160621011537.GP1521@codeaurora.org> References: <20160607204154.31967-1-maxime.ripard@free-electrons.com> <20160607204154.31967-5-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160607204154.31967-5-maxime.ripard@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07, Maxime Ripard wrote: > + > +#include > + > +#include "ccu_common.h" > + > +struct ccu_fixed_factor { > + u16 div; > + u16 mult; > + > + struct ccu_common common; Does this use the common structure although we have no usage for the members of struct ccu_common except struct clk_hw? I suppose this is done so registering a bunch of clks is easy? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project