From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754830AbcFUHdZ (ORCPT ); Tue, 21 Jun 2016 03:33:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754529AbcFUHdX (ORCPT ); Tue, 21 Jun 2016 03:33:23 -0400 Date: Tue, 21 Jun 2016 09:33:15 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Fixes on remote unwind Message-ID: <20160621073315.GA13670@krava> References: <1465380938-64371-1-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465380938-64371-1-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 21 Jun 2016 07:33:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2016 at 10:15:35AM +0000, He Kuang wrote: > The remote unwind can supported scenario where we collect on a x86_64 > machine and want to do analysis on a ARM64 or x86-32 machine. Though > this is not tested, after Arnaldo questioned the above issue, I tested > and found a bug. > > In util/unwind-libunwind-local.c, PERF_REG_SP/IP is used, but those > macros are assigned to the host platform, we should redefine them in > the wrapper file, for example in "util/libunwind/x86_32.c". > > After fixing this problem, i686 perf.data can be parsed on aarch64 > machine. > > To Arnaldo, I noticed that this patch > "perf tools: Find vdso supporting cross-platform analysis" > is not on "origin/perf/unwind" branch, this patch was applied, please > check if it was missed, the above test needs this patch. > > Thank you. > > He Kuang (3): > perf unwind: Change macro names of perf register > perf unwind: Fix wrongly used regs for x86_32 unwind > perf unwind: Fix wrongly used regs for aarch64 unwind for the patchset: Acked-by: Jiri Olsa thanks, jirka