From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462AbcFUJJL (ORCPT ); Tue, 21 Jun 2016 05:09:11 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:62351 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbcFUJJD (ORCPT ); Tue, 21 Jun 2016 05:09:03 -0400 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] scsi: wd7000: print sector number as 64-bit Date: Tue, 21 Jun 2016 11:02:39 +0200 Message-Id: <20160621090249.774301-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:YdYdbc5hO4ZLfwayhjm96XS1l4Ugos3gdAgas6GerxzkYeOwnPA xetlr3LgarOnseztxlVKP5bZD+FQSR3MrGfA52ZAoGHWzZuv4AzHKTGnW340uhRJC2F20bd r9lqwz6jIAHRi/DVqrKhINforfDZjRXuw6TwJ7HEzqEgSh4Mj35AXNuo32f5J+MLZRl/cAo HAEvvX+dWS4B8yhsT40QA== X-UI-Out-Filterresults: notjunk:1;V01:K0:G+zNoGliggQ=:e7xoOLGuazNKPqO0f1UQxq TeazngrpC2eL6VvMxRMWc8PbuhZYzjLDquGrT5bpUZk8kZIncVmVZqAPLPh0ZNMsKiidOQGEU PJwpJMQx6ncqBOwBVfVLAvWkYmfbD0AT4n4jCq/TGyxfMLVxOWas4dRGPcitz93/NhKEVgErX 8eNo+dgWvgGZ7tZBAQwbdpX8NTpjKOyAkkahFyIivHvrNmrTmvYvzwckwcGjFWcOAy8PrIb5J PPmMvC1DY8yBzBZYF+mDRAuoXR5vSfG+ReJZLc9gu2J32cbxQdCRZLbrHsE9mNSrqOAV839ug VQlkVxjZrbP/eneYyeWWLdzmJ/YoG8rXO26h6uh78aa3FbXvOEXmng+BxFUvyU4iurMLJdlzv 2DoIxg2g/CP2yakoPiTgyrs3F7QyXYRXEQazkRVQnecFhXoEWjMwTNYBkxCvSnANQ8Dmrs1Mx 2fzSGrf+eTqIY1z6twSwNJdA+2ir270PpXHYNP5v5HDVE17o+7js10sggVhth1fh45GmK0izM 832yerXSkyXJfmuipWBC5fHYVI/9lYA9AsMfRiqks70Nd5WXmbeImzp29oGT1X3gBYzvAenfg Hrkd85btE8yA/h26EuAGP0BuEpNt4RxGO9GGpoANUv65ujIdxGf+eTfQuUXDeEOejOd04x0MN GF2zs1S7X0Iwcui4AaoYlplgvJsQl5pqCXF+jL7YeBWXTgEnmXiMzt5ngulwhaUrjfwz93Gky U7Q05DF29rk/a40Xlirbpjqk4vnBC1sPhduKWltPGSae8/isH0GJBKFuLTu4EJ3bLGmnWSO3l Yf3UNbrC1hND4NvyDMeitIe0HR36BMOUmOjIptH1s3kWY7CzmXBo1r7wyXIJCQvVZwTugQ6sM BQzXIgSGE8WcgkXKeW1Q== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Enabling format checking in dprintk() shows that wd7000_biosparam uses an incorrect format string for sector_t: drivers/scsi/wd7000.c: In function 'wd7000_biosparam': drivers/scsi/wd7000.c:1594:21: error: format '%d' expects argument of type 'int', but argument 3 has type 'sector_t {aka long long unsigned int}' [-Werror=format=] As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints that with the correct format. The change to use no_printk() generally helps with finding this kind of hidden format string bug, and I found that when building with "-Wextra", which warned about an empty else clause in } else dprintk("ok!\n"); Signed-off-by: Arnd Bergmann --- v2: use %llu instead of %lld and use 'u64' instead of 's64' because sector_t is unsigned. drivers/scsi/wd7000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c index 0c0f17b9a3eb..409f959845c4 100644 --- a/drivers/scsi/wd7000.c +++ b/drivers/scsi/wd7000.c @@ -192,7 +192,7 @@ #ifdef WD7000_DEBUG #define dprintk printk #else -#define dprintk(format,args...) +#define dprintk no_printk #endif /* @@ -1591,8 +1591,8 @@ static int wd7000_biosparam(struct scsi_device *sdev, { char b[BDEVNAME_SIZE]; - dprintk("wd7000_biosparam: dev=%s, size=%d, ", - bdevname(bdev, b), capacity); + dprintk("wd7000_biosparam: dev=%s, size=%llu, ", + bdevname(bdev, b), (u64)capacity); (void)b; /* unused var warning? */ /* -- 2.9.0