From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751841AbcFUKHK (ORCPT ); Tue, 21 Jun 2016 06:07:10 -0400 Received: from smtpfb1-g21.free.fr ([212.27.42.9]:35200 "EHLO smtpfb1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbcFUKGq convert rfc822-to-8bit (ORCPT ); Tue, 21 Jun 2016 06:06:46 -0400 X-Greylist: delayed 1469 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jun 2016 06:06:44 EDT Date: Tue, 21 Jun 2016 11:40:44 +0200 From: Jean-Francois Moine To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , Chen-Yu Tsai , linux-clk@vger.kernel.org, Hans de Goede , Andre Przywara , Rob Herring , Vishnu Patekar , linux-arm-kernel@lists.infradead.org, Boris Brezillon , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 00/15] clk: sunxi: introduce "modern" clock support Message-Id: <20160621114044.811e2136eca5c1d863d79ac6@free.fr> In-Reply-To: <20160607204154.31967-1-maxime.ripard@free-electrons.com> References: <20160607204154.31967-1-maxime.ripard@free-electrons.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; armv7l-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Jun 2016 22:41:39 +0200 Maxime Ripard wrote: > The current code has been tested on the H3 and an Orange Pi PC, > including making sure that MMC still works, so the general approach > seems ok. > > Let me know what you think, Hi Maxime, I used your code in both the H3 and A83T, and it worked fine for the current clocks. But I had some problems with some features as the 'mode select' in the A83T MMC2 clock. Also, I think that you did not go far enough in the changes. For example, most clock gates as well as most resets could be removed from the DT and automatically set/de-asserted on clock prepare or clock enable. So, I am rewriting a generic sunxi clock driver into one file (about 1000 lines) and I have the full (simpler and clearer) description of the H3 and the A863T clocks. Coding is not finished yet. I will submit a RFC as soon as I will have something working. -- Ken ar c'hentań | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/