From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbcFUL4X (ORCPT ); Tue, 21 Jun 2016 07:56:23 -0400 Received: from mail.kernel.org ([198.145.29.136]:41824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbcFUL4V (ORCPT ); Tue, 21 Jun 2016 07:56:21 -0400 Date: Tue, 21 Jun 2016 14:55:54 +0300 From: Leon Romanovsky To: "Wei Hu (Xavier)" Cc: Lijun Ou , dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v10 08/22] IB/hns: Add icm support Message-ID: <20160621115554.GB9762@leon.nu> Reply-To: leon@kernel.org References: <1466087730-54856-1-git-send-email-oulijun@huawei.com> <1466087730-54856-9-git-send-email-oulijun@huawei.com> <20160617095834.GA5408@leon.nu> <57677314.70909@huawei.com> <20160620060614.GC1172@leon.nu> <5767A004.4060808@huawei.com> <20160620092719.GE1172@leon.nu> <5767BBDF.6010309@huawei.com> <20160620130422.GA4526@leon.nu> <5768C493.6000300@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bn2rw/3z4jIqBvZU" Content-Disposition: inline In-Reply-To: <5768C493.6000300@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 21, 2016 at 12:37:39PM +0800, Wei Hu (Xavier) wrote: >=20 >=20 > On 2016/6/20 21:04, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 17:27, Leon Romanovsky wrote: > >>>On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: > >>>>On 2016/6/20 14:06, Leon Romanovsky wrote: > >>>>>On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > >>>>>>On 2016/6/17 17:58, Leon Romanovsky wrote: > >>>>>>>On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > >>>>>>>>This patch mainly added icm support for RoCE. It initializes icm > >>>>>>>>which managers the relative memory blocks for RoCE. The data > >>>>>>>>structures of RoCE will be located in it. For example, CQ table, > >>>>>>>>QP table and MTPT table so on. > >>>>>>>> > >>>>>>>>Signed-off-by: Wei Hu > >>>>>>>>Signed-off-by: Nenglong Zhao > >>>>>>>>Signed-off-by: Lijun Ou > >>>>>>>>--- > >>>>>>><...> > >>>>>>> > >>>>>>>>+ > >>>>>Another question which you didn't answer [1]. > >>>>> > >>>>>"I wonder if you have the same needs for ICM as it is in mlx4 device. > >>>>>Do you have firmware?" > >>>>> > >>>>>[1] http://marc.info/?l=3Dlinux-rdma&m=3D146545553104913&w=3D2 > >>>>Hi, Leon > >>>> Now we haven't firmware. > >>>> But hardware still need memory for QPC\CQC\MTPT\mtt etc. > >>>ICM stands for InfiniHost (Interconnect) Context Memory is a specific > >>>memory place to share between host <-> FW and host <-> HW if HW is > >>>aware of specific structures. > >>> > >>>I assume that in your case, it is enough to allocate memory region and > >>>supply it to HW. Am I right? > >>For Our hardware, > >>1. ICM has a memory management method, It's very good for QPC\CQC\MTPT\= mtt > >>etc. we need it. > >You need special HW to leverage its. AFAIK it is Mellanox specific. > For our hardware, we use ICM to memory management, the memory shared with > host and HW. > QPC\CQC\MTPT\mtt has specific memory requirement. > QPC\CQC\MTPT need continuous memory. we use ICM to management the block of > memory. It's very good=EF=BC=81 I wasn't convinced why do you need to copy whole ICM logic which is specific to Mellanox. Your requirements can be implemented by standard CMA and/or DMA. > >>2. The meomry for QPC\CQC\MTPT\mtt only used for RoCE hardware and driv= er, > >>we don't want use MR. > >I didn't mean Infiniband MR, but memory region returned from standard > >allocation functions (kmalloc, ...). > > > >>3. Now we haven't firmware, maybe we need it next version. > >You are always invited to add support once it will be needed, no need to > >add it in advance. > > > >Thanks >=20 >=20 --Bn2rw/3z4jIqBvZU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXaStKAAoJEORje4g2clinZKQP/2w6OPnlEhhNCVXWLIW9J9sH Uy4+JdzDQJwFx6IuGTFrJ7gnA/gXImwrA5zmFYF3hiL8vkkFhZPKw2jM5eKzVc1/ wSVpYKrwOeE5mu3gWzvL9NWGz2qdUZd/InGVzxN9NAyT1GiJo57B9RqDyXE87fnS yBph7dKlugbioEX/EF4m6GsEtbSNJlZmNF/CB7nsukTrglAAudN/dZD9D9AVFXVH Hduj/dxo+iuvgujchtfbXBvUvDaNOkFcA2CDPfmk2P0of1DvGhkhtzWTyXHf6MjX wNHy8viqqq0LINAwndPYq8siSaCzCVxV2E1HKQwJmvpArGmhuBeaWO5zNdZ2sL/V /08OPrp3ayUloJw3tYup5cOaycWELN9rhAqg+I4dZMSFBHnwdScSZktclnCLeJLM Z+5MmqeMs0ro/4DvKD6D2wFLVkqLUHvSewvItN0cUj1Is+H1tsKF36CH8QsX5zB+ BZ0s120rkjqvno9eL0NXK7lOiyyigQeg6C+/HWBNA7xotXOL3TerFlCTZup+DH7v MwmA3HJK29fQPUYlKUEfOc+daak7op3EbwwRnLt16H3weha64/YMtqZjQLBU/IN8 v8Tl2q/rStZAG5PjKAl5KIUACs00O8q1cu2p85HsstHUnE2lYKbpgnKPxm3cWPWx wN9UPIh8YPUHQZtXMAaY =MxMy -----END PGP SIGNATURE----- --Bn2rw/3z4jIqBvZU--