From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751788AbcFUMsL (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 08:48:11 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:48861 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751432AbcFUMsJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 08:48:09 -0400
Date: Tue, 21 Jun 2016 14:47:40 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Yuyang Du <yuyang.du@intel.com>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Benjamin Segall <bsegall@google.com>, Paul Turner <pjt@google.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH 4/4] sched,fair: Fix PELT integrity for new tasks
Message-ID: <20160621124740.GN30921@twins.programming.kicks-ass.net>
References: <20160617120136.064100812@infradead.org>
 <20160617120454.150630859@infradead.org>
 <CAKfTPtAUtteP0V5-1u2n0YFDdFbZfwSqigHjOfM32Vbw3iAPbg@mail.gmail.com>
 <20160617142814.GT30154@twins.programming.kicks-ass.net>
 <20160617160239.GL30927@twins.programming.kicks-ass.net>
 <20160617161831.GM30927@twins.programming.kicks-ass.net>
 <20160620092339.GA4526@vingu-laptop>
 <20160621114335.GQ30909@twins.programming.kicks-ass.net>
 <CAKfTPtA87ST1uiVaABHDocxG=s8VGa0mmE8jdmVECZSoNJvEqw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtA87ST1uiVaABHDocxG=s8VGa0mmE8jdmVECZSoNJvEqw@mail.gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 21, 2016 at 02:36:46PM +0200, Vincent Guittot wrote:
> On 21 June 2016 at 13:43, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Mon, Jun 20, 2016 at 11:23:39AM +0200, Vincent Guittot wrote:
> >
> >> Don't we have to do a complete attach with attach_task_cfs_rq instead
> >> of just the load_avg ? to set also depth ?
> >
> > Hmm, yes, your sched_set_group() change seems to have munged this.
> >
> 
> I think that it was done by the attach_task_cfs_rq during the activate_task.
> Now, the attach is done in post_init_entity_util_avg. Can't we just
> set the depth in post_init_entity_util_avg ?

Yes, I actually had that patch for a little while.

But since its cgroup specific, I felt it should be in the cgroup code,
hence the current patch.