From: Rob Herring <robh@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 2/8] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC
Date: Tue, 21 Jun 2016 08:14:43 -0500 [thread overview]
Message-ID: <20160621131443.GA29350@rob-hp-laptop> (raw)
In-Reply-To: <1466391138-12862-3-git-send-email-wens@csie.org>
On Mon, Jun 20, 2016 at 10:52:12AM +0800, Chen-Yu Tsai wrote:
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> Changes since v2:
>
> - Fix interrupt line for ac100_codec in provided example.
>
> ---
> Documentation/devicetree/bindings/mfd/ac100.txt | 42 +++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ac100.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/ac100.txt b/Documentation/devicetree/bindings/mfd/ac100.txt
> new file mode 100644
> index 000000000000..a793954bb952
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ac100.txt
> @@ -0,0 +1,42 @@
> +X-Powers AC100 Codec/RTC IC device tree bindings
> +
> +AC100 is a audio codec and RTC subsystem combo IC. The 2 parts are
> +separated, including power supplies and interrupt lines, but share
> +a common register address space and host interface.
> +
> +Required properties:
> +- compatible: "x-powers,ac100"
> +- reg: The I2C slave address or RSB hardware address for the chip
> +- sub-nodes:
> + - codec
> + - compatible: "x-powers,ac100-codec"
> + - interrupt-parent: The parent interrupt controller
> + - interrupts: SoC NMI / GPIO interrupt connected to the IRQ_AUDIO pin
> + - rtc
> + - compatible: "x-powers,ac100-rtc"
> + - interrupt-parent: The parent interrupt controller
> + - interrupts: SoC NMI / GPIO interrupt connected to the IRQ_RTC pin
> + - #clock-cells: shall be 1
> + - clock-output-names: "cko1_rtc", "cko2_rtc", "cko3_rtc"
> + - see clock/clock-bindings.txt for common clock bindings
> +
> +Example:
> +
> +ac100: codec@e89 {
> + compatible = "x-powers,ac100";
> + reg = <0xe89>;
> +
> + ac100_codec {
Use generic node names and no underscores:
codec {
> + compatible = "x-powers,ac100-codec";
> + interrupt-parent = <&r_pio>;
> + interrupts = <0 9 IRQ_TYPE_LEVEL_LOW>; /* PL9 */
> + };
> +
> + ac100_rtc {
rtc {
> + compatible = "x-powers,ac100-rtc";
> + interrupt-parent = <&nmi_intc>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + #clock-cells = <1>;
> + clock-output-names = "cko1_rtc", "cko2_rtc", "cko3_rtc";
> + };
> +};
> --
> 2.8.1
>
next prev parent reply other threads:[~2016-06-21 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 2:52 [PATCH v3 0/8] mfd: ac100: Add support for X-Powers AC100 audio codec / RTC combo IC Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 1/8] regmap: Support bulk writes for devices without raw formatting Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 2/8] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC Chen-Yu Tsai
2016-06-21 13:14 ` Rob Herring [this message]
2016-06-22 4:16 ` Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 3/8] mfd: ac100: Add driver for X-Powers AC100 audio codec / RTC " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 4/8] rtc: ac100: Add RTC driver for X-Powers AC100 Chen-Yu Tsai
2016-06-26 0:30 ` Alexandre Belloni
2016-06-26 14:54 ` Chen-Yu Tsai
2016-06-26 1:02 ` Alexandre Belloni
2016-06-20 2:52 ` [PATCH v3 5/8] rtc: ac100: Add clk output support Chen-Yu Tsai
2016-06-22 10:02 ` Maxime Ripard
2016-06-22 10:11 ` Chen-Yu Tsai
2016-06-27 19:23 ` Maxime Ripard
2016-06-28 2:27 ` Chen-Yu Tsai
2016-06-26 0:45 ` Alexandre Belloni
2016-06-26 14:58 ` Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 6/8] ARM: dts: sun9i: a80-optimus: Add device node for AC100 Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 7/8] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-06-20 2:52 ` [PATCH v3 8/8] ARM: dts: sun9i: Switch to the AC100 RTC clock outputs for osc32k Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621131443.GA29350@rob-hp-laptop \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).