From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbcFUNf6 (ORCPT ); Tue, 21 Jun 2016 09:35:58 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:33722 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbcFUNfx (ORCPT ); Tue, 21 Jun 2016 09:35:53 -0400 Date: Tue, 21 Jun 2016 08:33:40 -0500 From: Rob Herring To: tthayer@opensource.altera.com Cc: bp@alien8.de, dougthompson@xmission.com, m.chehab@samsung.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, dinguyen@opensource.altera.com, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com Subject: Re: [PATCHv4 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding Message-ID: <20160621133340.GA9073@rob-hp-laptop> References: <1466434252-26107-1-git-send-email-tthayer@opensource.altera.com> <1466434252-26107-5-git-send-email-tthayer@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466434252-26107-5-git-send-email-tthayer@opensource.altera.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 09:50:49AM -0500, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > Add the device tree bindings needed to support the Altera Ethernet > FIFO buffers on the Arria10 chip. > > Signed-off-by: Thor Thayer > --- > v2 No Change > v3 Change to common compatible string based on maintainer comments > Add local IRQ values. > v4 Add compatible string for parent node. > --- > .../bindings/arm/altera/socfpga-eccmgr.txt | 24 ++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt > index 15eb0df..7c714ba 100644 > --- a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt > +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt > @@ -82,6 +82,14 @@ Required Properties: > - interrupts : Should be single bit error interrupt, then double bit error > interrupt, in this order. > > +Ethernet FIFO ECC > +Required Properties: > +- compatible : Should be "altr,socfpga-eth-mac-ecc" > +- reg : Address and size for ECC block registers. > +- parent : phandle to parent (altr,socfpga-stmmac) Ethernet node. Sorry if I wasn't clear before, but I was suggesting changing 'parent' to 'altr,ethernet-mac': altr,ethernet-mac = <&gmac0>; Rob