From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbcFUOqt (ORCPT ); Tue, 21 Jun 2016 10:46:49 -0400 Received: from 8bytes.org ([81.169.241.247]:55443 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbcFUOqs (ORCPT ); Tue, 21 Jun 2016 10:46:48 -0400 Date: Tue, 21 Jun 2016 16:46:46 +0200 From: Joerg Roedel To: Suravee Suthikulanit Cc: pbonzini@redhat.com, rkrcmar@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sherry.hurwitz@amd.com Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support Message-ID: <20160621144645.GF11432@8bytes.org> References: <1465855611-10092-1-git-send-email-suravee.suthikulpanit@amd.com> <20160621135043.GJ28248@8bytes.org> <88650292-bb48-a54c-296e-8680bc839e39@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88650292-bb48-a54c-296e-8680bc839e39@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 09:27:27AM -0500, Suthikulpanit, Suravee wrote: > On 6/21/2016 8:50 AM, Joerg Roedel wrote: > >The code has a few style issues (thing I'd implemented differently), but > >it looks functional. > > Anything in particular that you think I should improve or/and change? One thing I noticed were all the if (small IRTE) ... else (big IRTE) that would better be hidden behind function pointers. Also a few magic numbers are in there that could be replaced by proper defines. Joerg