From: Tejun Heo <tj@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
DingXiang <dingxiang@huawei.com>,
jejb@linux.vnet.ibm.com, Wei Fang <fangwei1@huawei.com>,
miaoxie@huawei.com, wangyijing@huawei.com,
zhangaihua1@huawei.com, zhaohongjiang@huawei.com,
houtao1@huawei.com, linux-scsi <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 resend] libata:fix kernel panic when hotplug
Date: Tue, 21 Jun 2016 11:47:00 -0400 [thread overview]
Message-ID: <20160621154700.GH3262@mtj.duckdns.org> (raw)
In-Reply-To: <CAPcyv4hnzAoiPQNHD_6C74exQrDQGaGG-fRw8XAAkj80bv5nqg@mail.gmail.com>
Hello,
On Mon, Jun 20, 2016 at 06:46:55PM -0700, Dan Williams wrote:
> On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen
> <martin.petersen@oracle.com> wrote:
> >>>>>> "Tejun" == Tejun Heo <tj@kernel.org> writes:
> >
> >>> In fact,we don't need libata to deal with hotplug in sas environment.
> >>> So we can't run ata hotplug task when ata port is sas host.
> >
> > Tejun> Martin, can you please confirm whether the above is true. If so,
> > Tejun> I'll route the patch through libata w/ stable cc'd.
> >
> > Not exactly a libsas expert. James? Dan?
>
> While it is true that libsas itself handles adding / removing devices
> we have historically avoided this conflict because
> ATA_PFLAG_SCSI_HOTPLUG is never set for libsas ata_ports. So the bug
> / behavior change is that ATA_PFLAG_SCSI_HOTPLUG gets set in the
> first place. Ignoring it is a band-aid / not the real fix afaics.
I see. I'll hold off for now then. Ding Xiang, can you find out
where that flag is getting set?
Thanks!
--
tejun
next prev parent reply other threads:[~2016-06-21 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 4:45 [PATCH V2 resend] libata:fix kernel panic when hotplug DingXiang
2016-06-16 20:20 ` Tejun Heo
2016-06-21 1:22 ` Martin K. Petersen
2016-06-21 1:46 ` Dan Williams
2016-06-21 15:47 ` Tejun Heo [this message]
2016-06-22 6:46 ` dingxiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621154700.GH3262@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dingxiang@huawei.com \
--cc=fangwei1@huawei.com \
--cc=houtao1@huawei.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=wangyijing@huawei.com \
--cc=zhangaihua1@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).