From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbcFUVWl (ORCPT ); Tue, 21 Jun 2016 17:22:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:37745 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbcFUVWk (ORCPT ); Tue, 21 Jun 2016 17:22:40 -0400 Date: Tue, 21 Jun 2016 23:21:13 +0200 From: "Luis R. Rodriguez" To: Julia Lawall Cc: "Luis R. Rodriguez" , dmitry.torokhov@gmail.com, tiwai@suse.de, ming.lei@canonical.com, stephen.boyd@linaro.org, deepa.kernel@gmail.com, chunkeey@googlemail.com, cocci@systeme.lip6.fr, jwboyer@fedoraproject.org, jslaby@suse.com, zohar@linux.vnet.ibm.com, dwmw2@infradead.org, hauke@hauke-m.de, broonie@kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, markivx@codeaurora.org, linux-kernel@vger.kernel.org, mmarek@suse.com, johannes@sipsolutions.net, torvalds@linux-foundation.org Subject: Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize Message-ID: <20160621212112.GX25646@wotan.suse.de> References: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> <20160621205100.GV25646@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 11:02:49PM +0200, Julia Lawall wrote: > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: > > That is sanitized as follows: > > > > # spatch only allows include directories with the syntax "-I include" > > # while gcc also allows "-Iinclude" and "-include include" > > COCCIINCLUDE=${LINUXINCLUDE//-I/-I } > > COCCIINCLUDE=${COCCIINCLUDE// -include/ --include} > > I don't get the second case. Is it to replace -include by --include? > Coccinelle actually supports both, although it doesn't advertise that. Oh neat, yeah. So a follow up patch later can be to remove that second line? If so as of what version of coccinelle? > Also, in LINUXINCLUDE, what is the meaning of -include? For Coccinelle, > it is not the same as -I. It is for files that should be included that > are not in the set of includes seen by whatever is the specified include > strategy (--all-includes, etc). The argument is a specific file name, not > a directory. It is a way of eg not bothering with --recursive-includes > when there is one or a few key header files that each file will need. Its used to force to include a single file, it is a file. > > So the point is to annotate that the .cocconfig is picked up first due > > to the fact make is used and its issued from the top level makefile > > and starts from the top level. The fact that --dir is used is important > > but secondary to its introduction as well. > > OK, the original text seemed to me to imply that running from the kernel > directory was essential to getting the kernels .cocciconfig, And what I meant to imply was that since coccicheck uses the kernel makefiles it would kick off from kernel proper. > so I wanted to point out that this is not the case. I should have elaborated with all these details, its perhaps best to be explicit about this so I can respin with a clearer commit log. Luis