From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
"Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr>,
Gilles.Muller@lip6.fr, mmarek@suse.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, markivx@codeaurora.org,
stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com,
broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de,
johannes@sipsolutions.net, chunkeey@googlemail.com,
hauke@hauke-m.de, jwboyer@fedoraproject.org,
dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com,
torvalds@linux-foundation.org, deepa.kernel@gmail.com,
cocci@systeme.lip6.fr
Subject: Re: [PATCH v3 3/8] coccicheck: enable parmap support
Date: Tue, 21 Jun 2016 23:39:06 +0200 [thread overview]
Message-ID: <20160621213906.GC25646@wotan.suse.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1606212331160.2040@localhost6.localdomain6>
On Tue, Jun 21, 2016 at 11:32:11PM +0200, Julia Lawall wrote:
>
>
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
>
> > On Tue, Jun 21, 2016 at 11:00:53PM +0200, Nicolas Palix (LIG) wrote:
> > > Hi,
> > >
> > > Le 21/06/16 à 22:43, Julia Lawall a écrit :
> > > >
> > > >
> > > >On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
> > > >
> > > >>On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote:
> > > >>>
> > > >>>
> > > >>>On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
> > > >>>
> > > >>>>Coccinelle has had parmap support since 1.0.2, this means
> > > >>>>it supports --jobs, enabling built-in multithreaded functionality,
> > > >>>>instead of needing one to script it out. Just look for --jobs
> > > >>>>in the help output to determine if this is supported.
> > > >>>>
> > > >>>>Also enable the load balancing to be dynamic, so that if a
> > > >>>>thread finishes early we keep feeding it.
> > > >>>>
> > > >>>>Note: now that we have all things handled for us, redirect stderr to
> > > >>>>stdout as well to capture any possible errors or warnings issued by
> > > >>>>coccinelle.
> > > >>>>
> > > >>>>If --jobs is not supported we fallback to the old mechanism.
> > > >>>>This also now accepts DEBUG_FILE= to specify where you want
> > > >>>>stderr to be redirected to, by default we redirect stderr to
> > > >>>>/dev/null.
> > > >>>
> > > >>>Why do you want to do something different for standard error in the parmap
> > > >>>and nonparmap case?
> > > >>
> > > >>We should just deprecate non-parmap later.
> > > >
> > > >that's not really getting at the point. I like the DEBUG_FILE= solution.
> > > >I don't like merging stderr and stdout. So you've put what to my mind is
> > > >the good solution only in the deprecated case (to my understanding of
> > > >the commit message).
> > >
> > > I agree. You're not just "enabling parmap support". You're
> > > also changing how messages to stderr are handled.
> > > Maybe add the DEBUG_FILE mechanism in a separate patch for both
> > > modes (parmap and non-parmap).
> >
> > I'd prefer to just rip out non-parmap support and bump coccinelle
> > requiremetns to at least 1.0.3, thoughts?
>
> There are already too many changes in this patch series.
>
> Also, I don't know what the 0-day people would find convenient.
I'd really prefer to not deal with supporting DEBUG_FILE for non-parmap
case due to the way parallelism is supported there, it uses wait(1) to
wait on the shell, and for spawning this nasty thing:
eval "$@ --max $NPROC --index $i &"
Specially since we are likely to be able to deprecate this sooner
rather than later I see little point in adding DEBUG_FILE into this
mess.
Luis
next prev parent reply other threads:[~2016-06-21 21:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 19:21 [PATCH v3 0/8] coccicheck: modernize Luis R. Rodriguez
2016-06-21 19:21 ` [PATCH v3 1/8] coccicheck: move spatch binary check up Luis R. Rodriguez
2016-06-21 20:34 ` Nicolas Palix (LIG)
2016-06-21 19:21 ` [PATCH v3 2/8] coccicheck: make SPFLAGS more useful Luis R. Rodriguez
2016-06-22 20:39 ` Nicolas Palix (LIG)
2016-06-21 19:21 ` [PATCH v3 3/8] coccicheck: enable parmap support Luis R. Rodriguez
2016-06-21 20:17 ` Julia Lawall
2016-06-21 20:39 ` Luis R. Rodriguez
2016-06-21 20:43 ` Julia Lawall
2016-06-21 20:54 ` Luis R. Rodriguez
2016-06-21 21:10 ` Julia Lawall
2016-06-21 21:27 ` Luis R. Rodriguez
2016-06-21 21:31 ` Julia Lawall
2016-06-21 21:00 ` Nicolas Palix (LIG)
2016-06-21 21:28 ` Luis R. Rodriguez
2016-06-21 21:32 ` Julia Lawall
2016-06-21 21:39 ` Luis R. Rodriguez [this message]
2016-06-21 21:44 ` Julia Lawall
2016-06-21 22:14 ` Luis R. Rodriguez
2016-06-22 5:25 ` Julia Lawall
2016-06-22 15:10 ` [Cocci] " Luis R. Rodriguez
2016-06-22 19:47 ` Julia Lawall
2016-06-21 19:21 ` [PATCH v3 4/8] coccicheck: replace --very-quiet with --quit when debugging Luis R. Rodriguez
2016-06-21 19:21 ` [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle Luis R. Rodriguez
2016-06-21 20:29 ` Julia Lawall
2016-06-21 23:43 ` Luis R. Rodriguez
2016-06-22 5:53 ` Julia Lawall
2016-06-21 21:07 ` Nicolas Palix (LIG)
2016-06-21 21:12 ` Julia Lawall
2016-06-21 23:38 ` Luis R. Rodriguez
2016-06-22 5:51 ` Julia Lawall
2016-06-21 19:21 ` [PATCH v3 6/8] coccicheck: add support for requring a coccinelle version Luis R. Rodriguez
2016-06-21 21:11 ` Nicolas Palix (LIG)
2016-06-21 19:21 ` [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation Luis R. Rodriguez
2016-06-21 21:14 ` Nicolas Palix (LIG)
2016-06-21 21:18 ` Julia Lawall
2016-06-22 0:07 ` Luis R. Rodriguez
2016-06-22 5:56 ` Julia Lawall
2016-06-21 19:21 ` [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci Luis R. Rodriguez
2016-06-21 20:36 ` Julia Lawall
2016-06-21 21:17 ` Nicolas Palix (LIG)
2016-06-21 20:13 ` [PATCH v3 0/8] coccicheck: modernize Julia Lawall
2016-06-21 20:51 ` [Cocci] " Luis R. Rodriguez
2016-06-21 21:02 ` Julia Lawall
2016-06-21 21:21 ` Luis R. Rodriguez
2016-06-21 21:30 ` Julia Lawall
2016-06-21 21:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621213906.GC25646@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=Gilles.Muller@lip6.fr \
--cc=Nicolas.Palix@imag.fr \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=chunkeey@googlemail.com \
--cc=cocci@systeme.lip6.fr \
--cc=deepa.kernel@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
--cc=jslaby@suse.com \
--cc=julia.lawall@lip6.fr \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=ming.lei@canonical.com \
--cc=mmarek@suse.com \
--cc=stephen.boyd@linaro.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).