From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbcFVANp (ORCPT ); Tue, 21 Jun 2016 20:13:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:50936 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbcFVANo (ORCPT ); Tue, 21 Jun 2016 20:13:44 -0400 Date: Wed, 22 Jun 2016 01:38:51 +0200 From: "Luis R. Rodriguez" To: Julia Lawall Cc: "Nicolas Palix (LIG)" , "Luis R. Rodriguez" , Gilles.Muller@lip6.fr, mmarek@suse.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, markivx@codeaurora.org, stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com, broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, deepa.kernel@gmail.com, cocci@systeme.lip6.fr Subject: Re: [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle Message-ID: <20160621233851.GJ25646@wotan.suse.de> References: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> <1466536893-23355-6-git-send-email-mcgrof@kernel.org> <3617d9eb-7f8e-a230-a78e-a5126abcbc2f@imag.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 11:12:54PM +0200, Julia Lawall wrote: > On Tue, 21 Jun 2016, Nicolas Palix (LIG) wrote: > > > Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : > > > Help Coccinelle when used against Linux with a set of sensible defaults > > > options for Linux. This hints to coccinelle git can be used for 'git grep' > > > queries over coccigrep. A timeout of 200 seconds should suffice for now. > > > > > > If you use idutils you can override for 'make coccicheck' by using the > > > SPFLAGS option as follows: > > > > > > First build the index, for example: > > > mkid -s > > > > > > Pick the cocci file you wnat to work with: > > > export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci > > > > > > Then run coccicheck: > > > $ make coccicheck V=1 MODE=report SPFLAGS="--use-idutils ID" > > > > > > Coccinelle supports reading .cocciconfig from different directories, > > > the later one overriding the previous reads in the following order: > > > > > > o Your current user's home directory is processed first > > > o Your directory from which spatch is called is processed next > > > o The directory provided with the --dir option is processed last, if used > > > > > > Signed-off-by: Luis R. Rodriguez > > Acked-by: Nicolas Palix > > Hmm, I can see at least some advantages to encouraging people to do it the > Coccinelle way, with the Coccinelle script rather than mkid directly. > Then, if we need some other features specific to Coccinelle, we can just > add them. I can simply document that if users are used to using their own target output file, and if they wanted it to be used by coccinelle simply symlinking .id-utils.index to it would enable coccinelle to pick it up by default. If that is done, would the new .cocciconfig not override though? Luis