From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbcFVKAD (ORCPT ); Wed, 22 Jun 2016 06:00:03 -0400 Received: from down.free-electrons.com ([37.187.137.238]:60008 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751010AbcFVJ7Y (ORCPT ); Wed, 22 Jun 2016 05:59:24 -0400 Date: Wed, 22 Jun 2016 11:57:23 +0200 From: Maxime Ripard To: luoyi.ly@gmail.com Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board Message-ID: <20160622095723.GU26668@lukather> References: <20160617095602.14612-1-luoyi.ly@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vKcNkqnJHUUp475E" Content-Disposition: inline In-Reply-To: <20160617095602.14612-1-luoyi.ly@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vKcNkqnJHUUp475E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jun 17, 2016 at 05:56:02PM +0800, luoyi.ly@gmail.com wrote: > From: Luo Yi >=20 > Add support for the Bananapi M1 Plus A20 development board from > sinovoip.com.cn . This board is nearly a clone of the Lemaker's > Bananapro, but differ with the wlan chipset connection and i2s pinout. > And I also enable the integrated audio codec on default. This patch content is fine, but there's a lot of small issues: - You're not indenting the nodes properly - You're missing your Signed-off-by tag - And probably other stuff This has all been reported by checkpatch. Make sure you run checkpatch, make the modifications needed so that you don't have any warnings or errors anymore, and resubmit it. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --vKcNkqnJHUUp475E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXamEDAAoJEBx+YmzsjxAgNk4QALX1xxElYy40/LlmIDYAKYER tyxzw4JHt04fidgeAvpnN3p/xahL+kRhiIV4LcJXyGQGDpF854VtRxCYItBhGchW 0GgZSyDVXRg0TVilgFG5eeocC9kmEwj3J41vqsCPHKOMCwkBXul3G/l88ZOi4LYS 8IGowQFIE9gD0ynHs2LweUJvKAac9zTcbKbMufFpQQLubBUXKjE8UoRcUZlwzBza bYpvIWflC+qQWjkHw6Et6crXivHVGO4fzPBfYa9MGNcvQtdjfT+Dx2/GPvUHtLe3 nLXKrMHt5hG673qOxAfwXx+X2seACZBTiZGvemmm4nrKbJ3RpIuz9UBylhABjRIa PCqazr05fnxZNxrGdcFi80r1ixDQQx0BGR3Vj0pVWfSnJG26p4aQQPnqyD4PSpT2 7szdP01P8w3KJbPKDVrjkdIKpwFzLRAWlf6qjQZuQsjwv7iXwBMnhMJvkjcE75In 6HpnO0pCpxwgEySS6UG/0IBuHLwve6hrPGW+XdVwgajHPBtqZx8nXq0CcTzbFgZu gam+JeS3kM8OXVWZkKeQMjDwcipfI6NJcdok+4YEWl2noENR2fbGqFKPAHMFzDHL fn6eTiXURGuuwcKNVuAVcErB06dYc6hnAU+G6qCRXBPoB9C2ZlGWCShF56y0d6lY 2Uh8LAx42hDU0iZknXb2 =bKrT -----END PGP SIGNATURE----- --vKcNkqnJHUUp475E--