linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: "Stephan Linz" <linz@li-pro.net>,
	linux-leds@vger.kernel.org, linux-ide@vger.kernel.org,
	"Joseph Jezak" <josejx@gentoo.org>,
	"Nico Macrionitis" <acrux@cruxppc.org>,
	"Jörg Sommer" <joerg@alea.gnuu.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity'
Date: Wed, 22 Jun 2016 11:16:04 +0100	[thread overview]
Message-ID: <20160622101603.GC25837@leverpostej> (raw)
In-Reply-To: <576A447F.2020002@samsung.com>

On Wed, Jun 22, 2016 at 09:55:43AM +0200, Jacek Anaszewski wrote:
> On 06/21/2016 05:05 PM, Mark Rutland wrote:
> >On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote:
> >>Cc: Joseph Jezak <josejx@gentoo.org>
> >>Cc: Nico Macrionitis <acrux@cruxppc.org>
> >>Cc: Jörg Sommer <joerg@alea.gnuu.de>
> >>Signed-off-by: Stephan Linz <linz@li-pro.net>
> >>---
> >>  Documentation/devicetree/bindings/leds/common.txt    | 2 +-
> >>  Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +-
> >>  Documentation/laptops/asus-laptop.txt                | 2 +-
> >>  Documentation/leds/leds-class.txt                    | 2 +-
> >>  4 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >>diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> >>index af10678..1e97169 100644
> >>--- a/Documentation/devicetree/bindings/leds/common.txt
> >>+++ b/Documentation/devicetree/bindings/leds/common.txt
> >>@@ -26,7 +26,7 @@ Optional properties for child nodes:
> >>       "default-on" - LED will turn on (but for leds-gpio see "default-state"
> >>  		    property in Documentation/devicetree/bindings/gpio/led.txt)
> >>       "heartbeat" - LED "double" flashes at a load average based rate
> >>-     "ide-disk" - LED indicates disk activity
> >>+     "disk-activity" - LED indicates disk activity
> >>       "timer" - LED flashes at a fixed, configurable rate
> >
> >We should not break the binding.
> >
> >Code must continue to support "ide-disk", though we can mark it
> >deprecated in the binding documentation, and update the in-kernel dts
> >files to use "disk-activity".
> 
> The code in the version 4 of the patchset supports also "ide-disk".

Ah, sorry, I missed v4.

> Stephan, could you send a new version of this patch, with preserved
> "ide-disk" property, marked as deprecated?

With that, feel free to add:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

  reply	other threads:[~2016-06-22 10:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 22:29 [PATCH v3 1/7] leds: convert IDE trigger to common disk trigger Stephan Linz
2016-06-08 22:29 ` [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Stephan Linz
2016-06-21 15:05   ` Mark Rutland
2016-06-22  7:55     ` Jacek Anaszewski
2016-06-22 10:16       ` Mark Rutland [this message]
2016-06-22 16:05       ` Stephan Linz
2016-06-23  6:40         ` Jacek Anaszewski
2016-06-23 19:38           ` [PATCH v5] " Stephan Linz
2016-06-24  6:50             ` Jacek Anaszewski
2016-06-24 17:18               ` Stephan Linz
2016-06-08 22:29 ` [PATCH v3 3/7] powerpc: use the new LED disk activity trigger Stephan Linz
2016-06-08 22:29 ` [PATCH v3 4/7] arm: " Stephan Linz
2016-06-09  7:18   ` Gregory CLEMENT
2016-06-08 22:29 ` [PATCH v3 5/7] mips: " Stephan Linz
2016-06-08 22:29 ` [PATCH v3 6/7] parisc: " Stephan Linz
2016-06-08 22:29 ` [PATCH v3 7/7] unicore32: " Stephan Linz
2016-06-09  7:29 ` [PATCH v3 1/7] leds: convert IDE trigger to common disk trigger Jacek Anaszewski
2016-06-09 22:27   ` Stephan Linz
2016-06-20  8:36 ` Jacek Anaszewski
2016-06-20 21:28   ` Stephan Linz
2016-06-21  7:13     ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622101603.GC25837@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=acrux@cruxppc.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=j.anaszewski@samsung.com \
    --cc=joerg@alea.gnuu.de \
    --cc=josejx@gentoo.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linz@li-pro.net \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).