From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org, rientjes@google.com, oleg@redhat.com,
vdavydov@parallels.com, mgorman@techsingularity.net,
hughd@google.com, riel@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: mm, oom_reaper: How to handle race with oom_killer_disable() ?
Date: Wed, 22 Jun 2016 14:08:43 +0200 [thread overview]
Message-ID: <20160622120843.GE9208@dhcp22.suse.cz> (raw)
In-Reply-To: <201606221957.DBC18723.LOFQSMHVJOFFOt@I-love.SAKURA.ne.jp>
On Wed 22-06-16 19:57:17, Tetsuo Handa wrote:
> Michal Hocko wrote:
[...]
> > That being said I guess the patch to try_to_freeze_tasks after
> > oom_killer_disable should be simple enough to go for now and stable
> > trees and we can come up with something less hackish later. I do not
> > like the fact that oom_killer_disable doesn't act as a full "barrier"
> > anymore.
> >
> > What do you think?
>
> I'm OK with calling try_to_freeze_tasks(true) again for Linux 4.6 and 4.7 kernels.
OK, I will resend the patch CC Rafael and stable.
> But if free memory is little such that oom_killer_disable() can not expect TIF_MEMDIE
> threads to clear TIF_MEMDIE by themselves (and therefore has to depend on the OOM
> reaper to clear TIF_MEMDIE on behalf of them after the OOM reaper reaped some memory),
> subsequent operations would be as well blocked waiting for an operation which cannot
> make any forward progress because it cannot proceed with an allocation. Then,
> oom_killer_disable() returns false after some timeout (i.e. "do not try to suspend
> when the system is almost OOM") will be a safer reaction.
Yes that is exactly what I meant by "oom_killer_disable has to give up"
alternative. pm suspend already has a notion of timeout for back off
and oom_killer_disable can use wait_even_timeout. But let's do that
separately.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-06-22 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 14:23 mm, oom_reaper: How to handle race with oom_killer_disable() ? Tetsuo Handa
2016-06-13 11:19 ` Michal Hocko
2016-06-21 8:31 ` Michal Hocko
2016-06-21 11:03 ` Tetsuo Handa
2016-06-21 11:46 ` Michal Hocko
2016-06-21 13:27 ` Michal Hocko
2016-06-21 15:32 ` Tetsuo Handa
2016-06-21 17:46 ` Michal Hocko
2016-06-21 21:47 ` Tetsuo Handa
2016-06-22 6:40 ` Michal Hocko
2016-06-22 6:50 ` Michal Hocko
2016-06-22 10:57 ` Tetsuo Handa
2016-06-22 12:08 ` Michal Hocko [this message]
2016-06-22 12:15 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622120843.GE9208@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).