From: Mark Rutland <mark.rutland@arm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/8] arm64: dts: db820c: add basic board support
Date: Wed, 22 Jun 2016 14:06:21 +0100 [thread overview]
Message-ID: <20160622130621.GB28950@leverpostej> (raw)
In-Reply-To: <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org>
On Tue, Jun 21, 2016 at 06:22:42PM +0100, Srinivas Kandagatla wrote:
> + chosen {
> + stdout-path = "serial0";
> + };
Please add the configuration (e.g. make this "serial0:115200n8"), as per
Documentation/devicetree/bindings/chosen.txt, so that we're not relying
on implicit defaults.
Otherwise this looks ok.
Thanks,
Mark.
next prev parent reply other threads:[~2016-06-22 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 17:22 [PATCH v2 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
2016-06-22 4:49 ` Bjorn Andersson
2016-06-22 8:52 ` Srinivas Kandagatla
2016-06-22 16:04 ` Bjorn Andersson
2016-06-22 13:06 ` Mark Rutland [this message]
2016-06-21 17:22 ` [PATCH v2 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
2016-06-21 17:22 ` [PATCH v2 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622130621.GB28950@leverpostej \
--to=mark.rutland@arm.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).