From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbcFVOYg (ORCPT ); Wed, 22 Jun 2016 10:24:36 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35193 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbcFVOYd (ORCPT ); Wed, 22 Jun 2016 10:24:33 -0400 Date: Wed, 22 Jun 2016 16:24:07 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Mario_Limonciello@Dell.com Cc: gabriele.mzt@gmail.com, mjg59@srcf.ucam.org, dvhart@infradead.org, kernel@kempniu.pl, luto@kernel.org, alex.hung@canonical.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Message-ID: <20160622142407.GH29844@pali> References: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com> <01b8e172bca546728b596c8cc4ebd932@ausx13mpc124.AMER.DELL.COM> <0d5a8762-b849-41c6-bfe5-e00da25d26d5@gmail.com> <201606152151.07407@pali> <20160622075602.GA29844@pali> <41f11bb2917349919e0b4eb21fab9a46@ausx13mpc124.AMER.DELL.COM> <20160622141239.GG29844@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 22 June 2016 14:21:25 Mario_Limonciello@Dell.com wrote: > > > For Linux I don’t think this is necessary and a NOOP is appropriate. > > > > > > There is also a second place that some older laptops had a battery "hotkey" > > > that would also emit 0xE00E. This was also picked up by quickset and would > > > show battery information. > > > > > > This shouldn't be blocked by kernel, I'd expect if someone wants to bind > > this > > > to another application from userspace they should be able to. > > > > Great! Can I send patch after which 0xe00e will be send to input layer as > > event KEY_BATTERY? > > > > Well that's why I was mentioning this in two places. If it's received from keyboard > recoding it as KEY_BATTERY sounds appropriate to me. If it's received from WMI, > it really shouldn't be set as anything for Linux to do. > > I don't think any apps will benefit from the notification to re-read battery > Information today. I mean for dell-wmi.c code. Why it should not be set to anything on Linux? -- Pali Rohár pali.rohar@gmail.com