From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbcFVQwR (ORCPT ); Wed, 22 Jun 2016 12:52:17 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:56652 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbcFVQwP (ORCPT ); Wed, 22 Jun 2016 12:52:15 -0400 Date: Wed, 22 Jun 2016 17:52:14 +0100 From: Al Viro To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 7/8] ncpfs: don't use ->d_time Message-ID: <20160622165213.GR14480@ZenIV.linux.org.uk> References: <1466606110-24297-1-git-send-email-mszeredi@redhat.com> <1466606110-24297-8-git-send-email-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466606110-24297-8-git-send-email-mszeredi@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2016 at 04:35:09PM +0200, Miklos Szeredi wrote: > Ncpfs stores a boolean value in ->d_fsdata as well as using d_time. > Introcude ncp_dentry to store both of these and make d_fsdata point to it. Umm... I'd ask if you've profiled that change (you are adding a bunch of dereferencing), but it's ncpfs we are talking about...