From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751133AbcFWEgC (ORCPT ); Thu, 23 Jun 2016 00:36:02 -0400 Received: from mail-bl2on0053.outbound.protection.outlook.com ([65.55.169.53]:41904 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750839AbcFWEgA (ORCPT ); Thu, 23 Jun 2016 00:36:00 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 23 Jun 2016 07:35:42 +0300 From: Yury Norov To: Szabolcs Nagy CC: , , , , , , , , , , , Andrew Pinski Subject: Re: [PATCH 01/27] [AARCH64] Fix utmp struct for compatibility reasons. Message-ID: <20160623043542.GA13449@yury-N73SV> References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-2-git-send-email-ynorov@caviumnetworks.com> <5769139E.7020805@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5769139E.7020805@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: HE1PR03CA0025.eurprd03.prod.outlook.com (10.163.170.163) To DM3PR07MB2249.namprd07.prod.outlook.com (10.164.33.147) X-MS-Office365-Filtering-Correlation-Id: 07bdc3d0-8275-4947-95b9-08d39b1fdbd6 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2249;2:LfD2qPAG6iULEP2jPvrItx8PgbaT0TOb/a2MBd2KOR3l1Ia+NB5yNkf2+7xN6mHeQGqqk+edPWWf98FLa+HDsnzJs1G43Na3tUS9J2jLTa3aM21nHQwDMio2jNq0K/bH/D/R2GQ8HfCU8HdrMd7s3vvZUhFh25S6DNkgABVuWv8JYGrB5Hin/PcKflgGOiEb;3:+GUCYlvChPXro6Vu3+V0fV94XgUtx1d/ceMDSDXSM8MwQcMEZFEwb1QUFkl1wEl9/KvjcVoi3BTlnAPVPkNXL2uF9TqEm5FsjgSjzdqo4TQ5T8iQ0FLpAEgGEVa4Oa8H X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2249; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2249;25:E6Ai7PrThwjjbfTYNcAuvQd9/8g9KXSfYpF0BP3gcbVyrrCjVpv0B57POvMKr2tN3aKf3sgPuEz8mE+LpQ+K02J7PSGopCYnbaa1Dqqtsolgq+KBK8dKgHkyhxj3EeRwkvbhVPClIQ+GEEdjq/i2Ufze2sfyKAoYxLJswU5y9H3MCZh1dzutA7y34LUVDocQijmrCQ9u5o/ut/KyDkVtE/CyX5//RHI6qGCRW2L/AvVjiMlbisOLURvqNrh4Rc0VrNc3hFc9rzjMz4lQhSrBt8UUDZm8WO0PifclTuJBTdSVDfqNuaiFBdwr5ksnSSyCoavnwniic5UJnoGObwuo/r+PlNnsbcGlMxDU1Vgp9pKLAmjmvZoPRA/c2ossWwXWXGDRsBqJAjS9sVhfKVEJu+Yhol8Yr7JAQn/2JSs+7grfHzsB6ExdsX0+QbIhAqHKj61GMtrIIkEaU17kCcd16KGHiAFhqlPnvZgJ+1o1u/KVe5LM3VxUJaXQcKAmUZ6v1otFlM8c+SLd8zkC5tnWeRmLiCANbMJojXRHSdhwwHwaCLLnn7s9IyhWNqaQu1CZJYUMsBGsqRXcJbPIdfQt3OzMbc++5fHI/dCQcb6u4obZajtH98UPcmHHUKnyzoHxLJ8ZDC+B1AYGBeGh+UE8g10hhpuX9TmvcHSACougJLSS1kFuhanm77dnGNkUZt2u46LwgCYVZ54r5+t7KRza1I8BDRzEJKJIk5aS4Y1iMxa9qcpIGqMBKWJtN1CJ+NN3 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2249;20:RlQEjhY7eBQa2nI2+e27AiUiT++orHGVgfXd+zjKMNI1lmxtWi/hhlcaYehkCQXRQkLOAT0lZLb93AjSdvwh5NatByVhW9CJYEKayeV6B6VvsMDTf9rltfZ1AFp9EmunX5UGd3kDe2JypdVsm9UWfFM0IzprdYCNhB/fpdBb5HlYgPFp1Viq46mbC1QPxUY4tG4Ffz8rQUqPyTA/XxXl+4L/c9P6LbD6mw9GkNbsHEE0yhZaMhc8XwIHPTkG15Touv7aTn8E+jaZ9R56mQCDkUhiEJ96GExB9NPGs19AO+kD3zxzmyDBVBDXGadFVOFyxYJrkUXQZ0xIQw1tLooKjRx0njDLDFii0MNewEhJ3gZ7aD20bEYlG65Bvn6pmMSm//c+kZCIZnbOfSQ40HzqjmwKZ0+QsLAjHk7gXphLQuiyXvzp6V2tCgzHQEO8On/6FpVqU1z7FwTTy6Bmr7JVcg086hQqMTii2yIyjp4zCqy4i59mhRMk3wL53mZWqGcXin7xr4z3jcecHLYTv06HW1WCM7um5noTmRkNwA0N9dB0FBi4kg6KSAp7qMuLMTGPGRzEv71HiVUxS05Zl0MJpguxxEtxIuSTB89IB9v2F74= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM3PR07MB2249;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2249; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2249;4:wt33rrjOuAm4fbnMZA7KxJTWBVeNwUYw6K/m6V2CmOnodfXEum/xQTFwilbr5XxsYJU5Rz0+Wj+LZgeOgBK2FeokE2GcSKspSBPyd8J5F46cIjWuuEKYL4dcgYHZ9pDZ8VkXmB+W9jJjg919yErxzHndcDH2OPUCm5inlsts30r876PIipUlypjlqEONvHvDgWRX9sPOjRobOQFYYpDOz0DMvT7mI1G1epO54yWfL7jYvq85X8PgeUO9xcX83twKSQxQKeXNCkSRkCs87xqXEFa1jWz7+KJQ4Dm87BuOk6fV6k6hJq7zIklSDntYp4FEzUkgi6sHwKtwoMlqlrcD1ww1pzpB9rkhJ4iWOC9lbFP8IAIuqrSdmMKuskr1a6D/5EgRJE0w2ZHQQ4vbHJ/0VN6jN29U41MAnHvGd+LNysjM+Ml+c7eQYqQNn/UAOR+g X-Forefront-PRVS: 098291215C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(189002)(24454002)(9686002)(7846002)(46406003)(106356001)(2906002)(92566002)(19580405001)(97756001)(76506005)(83506001)(50466002)(4001350100001)(23726003)(7736002)(305945005)(33656002)(68736007)(19580395003)(101416001)(97736004)(4326007)(54356999)(107886002)(76176999)(50986999)(1076002)(42186005)(3846002)(6116002)(77096005)(81166006)(81156014)(189998001)(2950100001)(8676002)(33716001)(105586002)(4001430100002)(47776003)(586003)(66066001)(110136002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2249;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR07MB2249;23:JoWoasgasSUcgJ8TJyzhb8Opt03HkfjdmjxW9BC8u?= =?us-ascii?Q?55QwY1hSgNqLdnMQwnDulgw4QFiZ1r/1J7orMFvWFkWO6cyrFhgVrzJKSeE6?= =?us-ascii?Q?MahfqotvjPr/OLDWuTwg3m3RKQT2YZtyyYsJ0EJU9B/1HU+kNYNAwg6y2ScO?= =?us-ascii?Q?dLCjRcMZmoqShki8JpdYnnIHbuIOrwbVqgk58jJ1jGSjYaErJ0aAJTTzrZ5b?= =?us-ascii?Q?op6A6SBJv70c1nmOxUIIoYFk++grneVwYoCvGttdQIWTMG6OKHc0RBnvBfMt?= =?us-ascii?Q?ybk9IUZ66gzmS2bmXXay5vn3YIlApC+YTi/z7A5BRZOM765rvQHxFfbA37sF?= =?us-ascii?Q?yutu6iWw04WPvkr7wkiishLO4unJdwz9rvYkSRMpRBS+a48eo+r3GeiITHtb?= =?us-ascii?Q?0cOnL0k4DdbQr9d9KW0Psi31XFJHNNX3DHR0YWQ9r3M30aTBxZ5Tl6MnUWVo?= =?us-ascii?Q?bWwhCxbx3tPVCD7e6vtAesAljJ+24HOQnMIIQPEdVwRR02hY1nrfcllL5bqf?= =?us-ascii?Q?NgaMQNjg0j5yrNcuqVvUqit0645y7N1XC2gXOnCuYtc5cR1gSbw9sIFrf3NQ?= =?us-ascii?Q?hLQu1Aq7BNCQtyTFcIiLbaY6Gu4LgKfDfYSJePsIGUKvRd39SbtxDHkhUQK3?= =?us-ascii?Q?ezLKS/lZf4GrWymv3wjguVAEeHgqDo7jNHlnFfsdSvY7J/Fq22XVIRskmooI?= =?us-ascii?Q?rVby+69EOFO+HF3zhzT6x4Oc0X88wvzXkspxT57pZ/VRlBRED6D2S9nL4Va4?= =?us-ascii?Q?+OC671SfkfY9wEf2evLGH5JUsD2Wb9Mm7U6Xv5UbjUB2NYWD9GAGujIoLOmx?= =?us-ascii?Q?px0ts5+OwX9Whc+5s1vOL/u+Zhk2PO4ayVPzRLpVvOM5YRfqXZkSqS5mIhiw?= =?us-ascii?Q?37B+61d7OI8E8LCwuouYTXvXYAStxmWITHsXcrSv/o2xOBHWa7khZIqsayXG?= =?us-ascii?Q?yDtVa//wjG625rEsM3Q7jBaJLLV/MMSd2tOFP6feyTX4wnO0wSq8SQfcXSs2?= =?us-ascii?Q?ti6ZrrDOrl2CXg9S2BTkkQB3VG/MhFm40U3B8XqNGIOUGNHlKoEb3lL1Lsb8?= =?us-ascii?Q?UogZ8tIN03nfYthphsY1Jka/PsjL9b8U8abdSZd1xtFzPlx2LRMNybuWzQBr?= =?us-ascii?Q?ijybIAOB9i+UdBf+31+wdZt3p7+ZukoNA4GaqphtpIMK+7Y2mMoeC0zSTFiD?= =?us-ascii?Q?bT8pYCANmGmN2id6rB2Etn/as8G18xMuNp4IRn6CrBWVwJeeoR2lTHtLQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2249;6:Tx00vZDgZmBSXauF8h4+k1gpstX3SBOP7G3ElztnYd5BP1frHhzlmnEFo929N6BA4KSqFCP8t/FR4WsddRlx9dtJXCMI47qUNNob2ZuC5GNXyY4qm7TiFiZ/VBlAQ+Dyb06bF8h7hXqOah5Y6DBoV3EbJ/eLP7OlzOLybGls85jfbygZI6VBbHWXIUto+ZtuOXBm3flNe9Iw52HeppWqKUktDA3WOrBUyMt8SQtcn4eUaHAoH58/jlk6LNbu1B19uMx13uHgwsZNsq1n+oGkjbQS66jUM5v88uoUMvaIrznFg0UERxa1obcCmXqNvFch;5:pSgqjPlS9zLKg1vo/AQgRPuYd4d+2qzLQ+SogBjW+WIVoZkM9TT3IhMWX/5GygcbFW9Zvs5wc+ClI47DR7h0BaXvwqNFZMZyLsyOdlFe1Q4CfiIBzrkX+ihdJUt5eMesDwfwLl37swVu4bSscAeoHQ==;24:tgG/Wg1WGg81L6wpKVLKxG3lDfmvEKUfdrM9CsFyvpy5yE5LXid+uyqJ+8rnRrtcrmwKZK431Fib+aU2e5XgnSFV/+LdhVeUREPNJUhAm2E=;7:WOd11HojyihsJImwMTL2SV5oC9T2yRPIgt4zySUZR9gdkGmIE7BtoUpmaklK91ZIEsXKRCOzNzZKKP943SJcJFeN40ZQVyHoht06XFjHCLFj5zT9XZp/lXeWBIF79l4CAEwmOxHEDJvERMIYvMPq18N/1kSvc9xVVuvxWsFolBmtjcHGF7lMJRbCporSQgkHlGpHlU4aAXFqcGxMf+fjlaloLRAxt/qRvTNLfqfCKWL4Hm2/rEc3fwu+at7+jC8kBvPoOQ6Zeag/WSNu+WjE0g== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2016 04:35:51.9072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2249 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 11:14:54AM +0100, Szabolcs Nagy wrote: > On 21/06/16 06:06, Yury Norov wrote: > > From: Andrew Pinski > > > > NOTE This is an ABI change for AARCH64. > > If you have some AARCH32 and AARCH64 applications and they both use > > utmp, one of them will fail due to the use of time_t inside the > > utmp binary format. > > > > This fixes the problem by setting __WORDSIZE_TIME64_COMPAT32. > > i think changing the abi now is not ok. > > this is BZ 17470 and i think it should be discussed separately > from ilp32. > > if it's possible to detect the utmp file format, that would > allow a reasonable fix, the way glibc changes the struct def > based on lp64 targets is non-conforming. Hi Joseph, Szabolcs, I revised it and found that we don't need __WORDSIZE_TIME64_COMPAT32 because ilp32 already has 32-bit time_t. So for now sysdeps/aarch64/bits/wordsize.h is looking like this: #ifdef __LP64__ # define __WORDSIZE 64 #else # define __WORDSIZE 32 # define __WORDSIZE32_SIZE_ULONG 1 # define __WORDSIZE32_PTRDIFF_LONG 1 #endif is it OK? Andrew?