From: Mel Gorman <email@example.com> To: Michal Hocko <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, Linux-MM <firstname.lastname@example.org>, Rik van Riel <email@example.com>, Vlastimil Babka <firstname.lastname@example.org>, Johannes Weiner <email@example.com>, LKML <firstname.lastname@example.org> Subject: Re: [PATCH 00/27] Move LRU page reclaim from zones to nodes v7 Date: Thu, 23 Jun 2016 13:33:47 +0100 [thread overview] Message-ID: <20160623123347.GV1868@techsingularity.net> (raw) In-Reply-To: <20160623112714.GF30077@dhcp22.suse.cz> On Thu, Jun 23, 2016 at 01:27:14PM +0200, Michal Hocko wrote: > On Thu 23-06-16 11:26:48, Mel Gorman wrote: > > On Tue, Jun 21, 2016 at 03:15:39PM +0100, Mel Gorman wrote: > > > The bulk of the updates are in response to review from Vlastimil Babka > > > and received a lot more testing than v6. > > > > > > > Hi Andrew, > > > > Please drop these patches again from mmotm. > > > > There has been a number of odd conflicts resulting in at least one major > > bug where a node-counter is used on a zone that will result in random > > behaviour. Some of the additional feedback is non-trivial and all of it > > will need to be resolved against the OOM detection rework and the huge > > tmpfs implementation. > > FWIW I haven't spotted any obvious misbehaving wrt. the OOM detection > rework. You have kept the per-zone counters which are used for the retry > logic so I think we should be safe. I am still reading through the > series though. > The main snag is NR_FILE_DIRTY and NR_WRITEBACK in should_reclaim_retry. It currently is a random number generator if it reads a zone stat instead of the node one. In some configurations, it even reads values after the stats array. -- Mel Gorman SUSE Labs
next prev parent reply other threads:[~2016-06-23 12:33 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-21 14:15 Mel Gorman 2016-06-21 14:15 ` [PATCH 01/27] mm, vmstat: Add infrastructure for per-node vmstats Mel Gorman 2016-06-21 14:15 ` [PATCH 02/27] mm, vmscan: Move lru_lock to the node Mel Gorman 2016-06-21 14:15 ` [PATCH 03/27] mm, vmscan: Move LRU lists to node Mel Gorman 2016-06-22 12:50 ` Vlastimil Babka 2016-06-21 14:15 ` [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis Mel Gorman 2016-06-22 14:04 ` Vlastimil Babka 2016-06-22 16:00 ` Vlastimil Babka 2016-06-23 11:07 ` Mel Gorman 2016-06-23 11:13 ` Michal Hocko 2016-06-23 10:58 ` Mel Gorman 2016-06-21 14:15 ` [PATCH 05/27] mm, vmscan: Have kswapd only scan based on the highest requested zone Mel Gorman 2016-06-21 14:15 ` [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes Mel Gorman 2016-06-21 14:15 ` [PATCH 07/27] mm, vmscan: Remove balance gap Mel Gorman 2016-06-21 14:15 ` [PATCH 08/27] mm, vmscan: Simplify the logic deciding whether kswapd sleeps Mel Gorman 2016-06-22 15:30 ` Vlastimil Babka 2016-06-21 14:15 ` [PATCH 09/27] mm, vmscan: By default have direct reclaim only shrink once per node Mel Gorman 2016-06-21 14:15 ` [PATCH 10/27] mm, vmscan: Remove duplicate logic clearing node congestion and dirty state Mel Gorman 2016-06-21 14:15 ` [PATCH 11/27] mm: vmscan: Do not reclaim from kswapd if there is any eligible zone Mel Gorman 2016-06-21 14:15 ` [PATCH 12/27] mm, vmscan: Make shrink_node decisions more node-centric Mel Gorman 2016-06-22 13:20 ` Michal Hocko 2016-06-22 15:42 ` Vlastimil Babka 2016-06-21 14:15 ` [PATCH 13/27] mm, memcg: Move memcg limit enforcement from zones to nodes Mel Gorman 2016-06-22 13:15 ` Michal Hocko 2016-06-21 14:15 ` [PATCH 14/27] mm, workingset: Make working set detection node-aware Mel Gorman 2016-06-21 14:15 ` [PATCH 15/27] mm, page_alloc: Consider dirtyable memory in terms of nodes Mel Gorman 2016-06-22 14:15 ` Michal Hocko 2016-06-22 14:27 ` Michal Hocko 2016-06-23 12:53 ` Mel Gorman 2016-06-23 13:13 ` Michal Hocko 2016-06-21 14:15 ` [PATCH 16/27] mm: Move page mapped accounting to the node Mel Gorman 2016-06-21 22:32 ` Andrew Morton 2016-06-23 8:35 ` Mel Gorman 2016-06-22 14:35 ` Michal Hocko 2016-06-21 14:15 ` [PATCH 17/27] mm: Rename NR_ANON_PAGES to NR_ANON_MAPPED Mel Gorman 2016-06-22 14:28 ` Michal Hocko 2016-06-21 14:15 ` [PATCH 18/27] mm: Move most file-based accounting to the node Mel Gorman 2016-06-22 14:38 ` Michal Hocko 2016-06-21 14:15 ` [PATCH 19/27] mm: Move vmscan writes and file write " Mel Gorman 2016-06-22 14:40 ` Michal Hocko 2016-06-23 13:57 ` Mel Gorman 2016-06-23 14:06 ` Vlastimil Babka 2016-06-23 16:03 ` Mel Gorman 2016-06-21 14:15 ` [PATCH 20/27] mm, vmscan: Update classzone_idx if buffer_heads_over_limit Mel Gorman 2016-06-22 14:49 ` Michal Hocko 2016-06-21 14:16 ` [PATCH 21/27] mm, vmscan: Only wakeup kswapd once per node for the requested classzone Mel Gorman 2016-06-22 16:08 ` Vlastimil Babka 2016-06-21 14:16 ` [PATCH 22/27] mm: Convert zone_reclaim to node_reclaim Mel Gorman 2016-06-21 14:16 ` [PATCH 23/27] mm, vmscan: Add classzone information to tracepoints Mel Gorman 2016-06-21 14:16 ` [PATCH 24/27] mm, page_alloc: Remove fair zone allocation policy Mel Gorman 2016-06-21 14:16 ` [PATCH 25/27] mm: page_alloc: Cache the last node whose dirty limit is reached Mel Gorman 2016-06-21 14:16 ` [PATCH 26/27] mm: vmstat: Replace __count_zone_vm_events with a zone id equivalent Mel Gorman 2016-06-21 14:16 ` [PATCH 27/27] mm: vmstat: Account per-zone stalls and pages skipped during reclaim Mel Gorman 2016-06-23 10:26 ` [PATCH 00/27] Move LRU page reclaim from zones to nodes v7 Mel Gorman 2016-06-23 11:27 ` Michal Hocko 2016-06-23 12:33 ` Mel Gorman [this message] 2016-06-23 12:44 ` Michal Hocko 2016-06-23 21:45 ` Andrew Morton 2016-06-24 6:35 ` Balbir Singh 2016-06-24 7:50 ` Mel Gorman 2016-06-27 12:48 ` Balbir Singh -- strict thread matches above, loose matches on Subject: below -- 2016-06-21 11:43 Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160623123347.GV1868@techsingularity.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 00/27] Move LRU page reclaim from zones to nodes v7' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).