From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355AbcFXHHx (ORCPT ); Fri, 24 Jun 2016 03:07:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56334 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbcFXHHw (ORCPT ); Fri, 24 Jun 2016 03:07:52 -0400 Date: Fri, 24 Jun 2016 09:07:43 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, Arnaldo Carvalho de Melo Subject: Re: [PATCH 4/6] perf ctf: Generate comm event to CTF output Message-ID: <20160624070743.GB10142@krava> References: <1466673383-105778-1-git-send-email-wangnan0@huawei.com> <1466673383-105778-5-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466673383-105778-5-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 24 Jun 2016 07:07:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 09:16:21AM +0000, Wang Nan wrote: > If non_sample is selected, convert comm event to output CTF stream. > > setup_non_sample_events() is called if non_sample is selected. It creates > a comm_class for comm event. > > Use macros to generate and process_comm_event and add_comm_event. These > macros can be reused for other non-sample events. > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > --- > tools/perf/util/data-convert-bt.c | 108 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > > diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c > index 0bc3ee2..bc6d42b 100644 > --- a/tools/perf/util/data-convert-bt.c > +++ b/tools/perf/util/data-convert-bt.c > @@ -68,6 +68,7 @@ struct ctf_writer { > }; > struct bt_ctf_field_type *array[6]; > } data; > + struct bt_ctf_event_class *comm_class; > }; > > struct convert { > @@ -761,6 +762,55 @@ static int process_sample_event(struct perf_tool *tool, > return cs ? 0 : -1; > } > > +#define __NON_SAMPLE_SET_FIELD(_name, _type, _field) \ > +do { \ > + ret = value_set_##_type(cw, event, #_field, _event->_name._field);\ > + if (ret) \ > + return -1; \ > +} while(0) > + > +#define __FUNC_PROCESS_NON_SAMPLE(_name, body) \ > +static int process_##_name##_event(struct perf_tool *tool, \ > + union perf_event *_event, \ > + struct perf_sample *sample, \ > + struct machine *machine) \ > +{ \ > + struct convert *c = container_of(tool, struct convert, tool);\ > + struct ctf_writer *cw = &c->writer; \ > + struct bt_ctf_event_class *event_class = cw->_name##_class;\ > + struct bt_ctf_event *event; \ > + struct ctf_stream *cs; \ > + int ret; \ > + \ > + event = bt_ctf_event_create(event_class); \ > + if (!event) { \ > + pr_err("Failed to create an CTF event\n"); \ > + return -1; \ > + } \ > + \ > + bt_ctf_clock_set_time(cw->clock, sample->time); \ coudl you please also add the global stats update, so we get the statistics straight at the end? /* update stats */ c->events_count++; c->events_size += _event->header.size; thanks, jirka