From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Wang Nan <wangnan0@huawei.com>,
linux-kernel@vger.kernel.org, pi3orama@163.com,
lizefan@huawei.com
Subject: Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF
Date: Fri, 24 Jun 2016 09:41:13 -0300 [thread overview]
Message-ID: <20160624124113.GA3324@kernel.org> (raw)
In-Reply-To: <20160624122907.GF10142@krava>
Em Fri, Jun 24, 2016 at 02:29:07PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> > After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> > makes inconvience. For example, in perf script output we know which
> > process issue an event like this:
> >
> > compiz 19361 [001] 3275709.313929: raw_syscalls:sys_exit: NR 7 = 0
> >
> > After converting to CTF, we only get this:
> >
> > [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> >
> > Currently, if we want to find the name and parent of a process, we
> > have to collect 'sched:sched_switch' event.
> >
> > This patch set adds a '--all' option to 'perf convert', converts comm,
> > fork and exit events to CTF output. CTF user now can track the mapping
> > by their own.
> >
> > v1 -> v2: Report number of sample and non-sample events when finish.
> > rename opts.non_sample to opts.all.
> >
> > Wang Nan (7):
> > perf ctf: Add value_set_string() helper
> > perf ctf: Pass convert options through opts structure
> > perf ctf: Add 'all' option
> > perf ctf: Prepare collect non-sample events
> > perf ctf: Generate comm event to CTF output
> > perf ctf: Add '--all' option for 'perf data convert'
> > perf ctf: Generate fork and exit events to CTF output
>
> I can't compile unless I can include config.h
Waiting for this fix to proceed, but it seems we don't have this covered
in 'build-test', right? ;-)
- Arnaldo
> [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
> BUILD: Doing 'make -j4' parallel build
> CC util/data-convert-bt.o
> util/data-convert-bt.c: In function ‘convert__config’:
> util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
> c->queue_size = perf_config_u64(var, value);
> ^
> util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
> c->queue_size = perf_config_u64(var, value);
> ^
> util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
> perf_config(convert__config, &c);
> ^
> util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
>
>
> your compiler's not that strict I guess ;-)
> I'll post it shortly
>
> jirka
>
> ---
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 79082782e7d2..4b68e7b9ee0c 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -26,6 +26,7 @@
> #include "evlist.h"
> #include "evsel.h"
> #include "machine.h"
> +#include "config.h"
>
> #define pr_N(n, fmt, ...) \
> eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)
next prev parent reply other threads:[~2016-06-24 12:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 11:22 [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Wang Nan
2016-06-24 11:22 ` [PATCH v2 1/7] perf ctf: Add value_set_string() helper Wang Nan
2016-06-29 9:45 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 2/7] perf ctf: Pass convert options through opts structure Wang Nan
2016-06-29 9:45 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 3/7] perf ctf: Add 'all' option Wang Nan
2016-06-29 9:46 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 4/7] perf ctf: Prepare collect non-sample events Wang Nan
2016-06-29 9:46 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 5/7] perf ctf: Generate comm event to CTF output Wang Nan
2016-06-29 9:46 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 6/7] perf ctf: Add '--all' option for 'perf data convert' Wang Nan
2016-06-29 9:47 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 7/7] perf ctf: Generate fork and exit events to CTF output Wang Nan
2016-06-29 9:47 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 12:28 ` [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Jiri Olsa
2016-06-27 19:03 ` Arnaldo Carvalho de Melo
2016-06-24 12:29 ` Jiri Olsa
2016-06-24 12:33 ` pi3orama
2016-06-24 12:55 ` Jiri Olsa
2016-06-24 12:41 ` Arnaldo Carvalho de Melo [this message]
2016-06-24 12:43 ` pi3orama
2016-06-24 13:08 ` Jiri Olsa
2016-06-24 12:44 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624124113.GA3324@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).