From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Daniel Danzberger <daniel@dd-wrt.com>
Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stephen@networkplumber.org,
davem@davemloft.net
Subject: Re: [PATCH net] Bridge: Fix ipv6 mc snooping if bridge has no ipv6 address
Date: Fri, 24 Jun 2016 15:24:41 +0200 [thread overview]
Message-ID: <20160624132441.GJ5511@otheros> (raw)
In-Reply-To: <1466764518-11358-1-git-send-email-daniel@dd-wrt.com>
On Fri, Jun 24, 2016 at 12:35:18PM +0200, Daniel Danzberger wrote:
> The bridge is falsly dropping ipv6 mulitcast packets if there is:
> 1. No ipv6 address assigned on the brigde.
> 2. No external mld querier present.
> 3. The internal querier enabled.
>
> When the bridge fails to build mld queries, because it has no
> ipv6 address, it slilently returns, but keeps the local querier enabled.
> This specific case causes confusing packet loss.
>
> Ipv6 multicast snooping can only work if:
> a) An external querier is present
> OR
> b) The bridge has an ipv6 address an is capable of sending own queries
>
> Otherwise it has to forward/flood the ipv6 multicast traffic,
> because snooping cannot work.
>
> This patch fixes the issue by adding a flag to the bridge struct that
> indicates that there is currently no ipv6 address assinged to the bridge
> and returns a false state for the local querier in
> __br_multicast_querier_exists().
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
next prev parent reply other threads:[~2016-06-24 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 10:35 [PATCH net] Bridge: Fix ipv6 mc snooping if bridge has no ipv6 address Daniel Danzberger
2016-06-24 13:24 ` Linus Lüssing [this message]
2016-06-25 14:20 ` Linus Lüssing
2016-06-28 12:04 ` David Miller
2016-06-28 13:22 ` Linus Lüssing
2016-06-28 9:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624132441.GJ5511@otheros \
--to=linus.luessing@c0d3.blue \
--cc=bridge@lists.linux-foundation.org \
--cc=daniel@dd-wrt.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).