From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Ganesh Mahendran <opensource.ganesh@gmail.com>,
vbabka@suse.cz, iamjoonsoo.kim@lge.com, mhocko@suse.com,
mina86@mina86.com, minchan@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/compaction: remove unnecessary order check in try_to_compact_pages()
Date: Fri, 24 Jun 2016 13:58:39 -0700 [thread overview]
Message-ID: <20160624135839.d27727e6ba9ab4b4aff0cc32@linux-foundation.org> (raw)
In-Reply-To: <576115DC.5030601@linux.vnet.ibm.com>
On Wed, 15 Jun 2016 14:16:20 +0530 Anshuman Khandual <khandual@linux.vnet.ibm.com> wrote:
> On 06/15/2016 12:22 PM, Ganesh Mahendran wrote:
> > The caller __alloc_pages_direct_compact() already check (order == 0).
> > So no need to check again.
>
> Yeah, the caller (__alloc_pages_direct_compact) checks if the order of
> allocation is 0. But we can remove it there and keep it in here as this
> is the actual entry point for direct page compaction.
I think the check in __alloc_pages_direct_compact() is OK - it's a bit
silly to do a (small) bunch of additional work in
__alloc_pages_direct_compact() when orer==0.
prev parent reply other threads:[~2016-06-24 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 6:52 [PATCH] mm/compaction: remove unnecessary order check in try_to_compact_pages() Ganesh Mahendran
2016-06-15 8:46 ` Anshuman Khandual
2016-06-24 20:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624135839.d27727e6ba9ab4b4aff0cc32@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=opensource.ganesh@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).