From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbcFXPWA (ORCPT ); Fri, 24 Jun 2016 11:22:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43813 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbcFXPV5 (ORCPT ); Fri, 24 Jun 2016 11:21:57 -0400 Date: Fri, 24 Jun 2016 10:21:53 -0500 From: Josh Poimboeuf To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Linus Torvalds , Jann Horn , Heiko Carstens , Vladimir Davydov , Johannes Weiner , Michal Hocko , linux-mm@kvack.org Subject: Re: [PATCH v4 06/16] mm: Track NR_KERNEL_STACK in KiB instead of number of stacks Message-ID: <20160624152153.k53i4m3iepoh4yax@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 24 Jun 2016 15:21:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 09:23:01PM -0700, Andy Lutomirski wrote: > Currently, NR_KERNEL_STACK tracks the number of kernel stacks in a > zone. This only makes sense if each kernel stack exists entirely in > one zone, and allowing vmapped stacks could break this assumption. > > Since frv has THREAD_SIZE < PAGE_SIZE, we need to track kernel stack > allocations in a unit that divides both THREAD_SIZE and PAGE_SIZE on > all architectures. Keep it simple and use KiB. > > Cc: Vladimir Davydov > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: linux-mm@kvack.org > Reviewed-by: Vladimir Davydov > Acked-by: Michal Hocko > Signed-off-by: Andy Lutomirski Reviewed-by: Josh Poimboeuf -- Josh