From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbcFXPWR (ORCPT ); Fri, 24 Jun 2016 11:22:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44282 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbcFXPWP (ORCPT ); Fri, 24 Jun 2016 11:22:15 -0400 Date: Fri, 24 Jun 2016 10:22:12 -0500 From: Josh Poimboeuf To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Linus Torvalds , Jann Horn , Heiko Carstens , Vladimir Davydov , Johannes Weiner , Michal Hocko , linux-mm@kvack.org Subject: Re: [PATCH v4 07/16] mm: Fix memcg stack accounting for sub-page stacks Message-ID: <20160624152212.5uutwkvfmj6sr24c@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 24 Jun 2016 15:22:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 09:23:02PM -0700, Andy Lutomirski wrote: > We should account for stacks regardless of stack size, and we need > to account in sub-page units if THREAD_SIZE < PAGE_SIZE. Change the > units to kilobytes and Move it into account_kernel_stack(). > > Fixes: 12580e4b54ba8 ("mm: memcontrol: report kernel stack usage in cgroup2 memory.stat") > Cc: Vladimir Davydov > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: linux-mm@kvack.org > Reviewed-by: Vladimir Davydov > Acked-by: Michal Hocko > Signed-off-by: Andy Lutomirski Reviewed-by: Josh Poimboeuf -- Josh