From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbcFXPb4 (ORCPT ); Fri, 24 Jun 2016 11:31:56 -0400 Received: from mail-yw0-f175.google.com ([209.85.161.175]:33624 "EHLO mail-yw0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbcFXPby (ORCPT ); Fri, 24 Jun 2016 11:31:54 -0400 Date: Fri, 24 Jun 2016 11:31:51 -0400 From: Tejun Heo To: Aleksa Sarai Cc: Jonathan Corbet , Li Zefan , Johannes Weiner , Kenny Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 1/2] cgroup: pids: show number of failed forks since limit reset Message-ID: <20160624153151.GQ3262@mtj.duckdns.org> References: <20160624030049.13341-1-asarai@suse.de> <20160624030049.13341-2-asarai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160624030049.13341-2-asarai@suse.de> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Jun 24, 2016 at 01:00:48PM +1000, Aleksa Sarai wrote: > This allows users to dynamically adjust their limits based on how many > failed forks happened since they last reset their limits, otherwise they > would have to track (in a racy way) how many limit failures there were > since the last limit change manually. In addition, we log the first > failure since the limit was reset (which was the original semantics of > the patchset). Isn't that trivially achievable by reading the counter and then calculating the diff? I don't think it matters all that much whether the log message is printed once per cgroup or per config-change. It's just a hint for the admin to avoid setting her off on a wild goose chase. Thanks. -- tejun