From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbcFXPe3 (ORCPT ); Fri, 24 Jun 2016 11:34:29 -0400 Received: from foss.arm.com ([217.140.101.70]:59192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbcFXPe2 (ORCPT ); Fri, 24 Jun 2016 11:34:28 -0400 Date: Fri, 24 Jun 2016 16:34:24 +0100 From: Catalin Marinas To: Andre Przywara Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/6] arm64: errata: Calling enable functions for CPU errata too Message-ID: <20160624153423.GF22608@e104818-lin.cambridge.arm.com> References: <1462812590-4494-1-git-send-email-andre.przywara@arm.com> <1462812590-4494-5-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462812590-4494-5-git-send-email-andre.przywara@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2016 at 05:49:48PM +0100, Andre Przywara wrote: > Currently we call the (optional) enable function for CPU _features_ > only. As CPU _errata_ descriptions share the same data structure and > having an enable function is useful for errata as well (for instance > to set bits in SCTLR), lets call it when enumerating erratas too. > > Signed-off-by: Andre Przywara > --- > arch/arm64/include/asm/cpufeature.h | 2 ++ > arch/arm64/kernel/cpu_errata.c | 5 +++++ > arch/arm64/kernel/cpufeature.c | 4 ++-- > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > index b9b6494..cb8fb2c 100644 > --- a/arch/arm64/include/asm/cpufeature.h > +++ b/arch/arm64/include/asm/cpufeature.h > @@ -174,7 +174,9 @@ void __init setup_cpu_features(void); > > void update_cpu_capabilities(const struct arm64_cpu_capabilities *caps, > const char *info); > +void enable_cpu_capabilities(const struct arm64_cpu_capabilities *caps); > void check_local_cpu_errata(void); > +void __init enable_cpu_errata(void); Nitpick: I would rather call this enable_errata_workarounds since errata are already enabled by in hardware ;). -- Catalin